Skip to content

Commit 36dd494

Browse files
Delete stray appengine service, minor fixups (#8219) (#5823)
Signed-off-by: Modular Magician <[email protected]>
1 parent 4479779 commit 36dd494

7 files changed

+26
-4
lines changed

.changelog/8219.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
```release-note:none
2+
```

google-beta/iam_iap_app_engine_service_generated_test.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -400,6 +400,7 @@ resource "google_app_engine_standard_app_version" "version" {
400400
service = "default"
401401
runtime = "nodejs10"
402402
noop_on_destroy = true
403+
403404
entrypoint {
404405
shell = "node ./app.js"
405406
}
@@ -465,6 +466,7 @@ resource "google_app_engine_standard_app_version" "version" {
465466
service = "default"
466467
runtime = "nodejs10"
467468
noop_on_destroy = true
469+
468470
entrypoint {
469471
shell = "node ./app.js"
470472
}
@@ -545,6 +547,7 @@ resource "google_app_engine_standard_app_version" "version" {
545547
service = "default"
546548
runtime = "nodejs10"
547549
noop_on_destroy = true
550+
548551
entrypoint {
549552
shell = "node ./app.js"
550553
}
@@ -612,6 +615,7 @@ resource "google_app_engine_standard_app_version" "version" {
612615
service = "default"
613616
runtime = "nodejs10"
614617
noop_on_destroy = true
618+
615619
entrypoint {
616620
shell = "node ./app.js"
617621
}
@@ -677,6 +681,7 @@ resource "google_app_engine_standard_app_version" "version" {
677681
service = "default"
678682
runtime = "nodejs10"
679683
noop_on_destroy = true
684+
680685
entrypoint {
681686
shell = "node ./app.js"
682687
}
@@ -742,6 +747,7 @@ resource "google_app_engine_standard_app_version" "version" {
742747
service = "default"
743748
runtime = "nodejs10"
744749
noop_on_destroy = true
750+
745751
entrypoint {
746752
shell = "node ./app.js"
747753
}
@@ -812,6 +818,7 @@ resource "google_app_engine_standard_app_version" "version" {
812818
service = "default"
813819
runtime = "nodejs10"
814820
noop_on_destroy = true
821+
815822
entrypoint {
816823
shell = "node ./app.js"
817824
}
@@ -904,6 +911,7 @@ resource "google_app_engine_standard_app_version" "version" {
904911
service = "default"
905912
runtime = "nodejs10"
906913
noop_on_destroy = true
914+
907915
entrypoint {
908916
shell = "node ./app.js"
909917
}
@@ -974,6 +982,7 @@ resource "google_app_engine_standard_app_version" "version" {
974982
service = "default"
975983
runtime = "nodejs10"
976984
noop_on_destroy = true
985+
977986
entrypoint {
978987
shell = "node ./app.js"
979988
}
@@ -1066,6 +1075,7 @@ resource "google_app_engine_standard_app_version" "version" {
10661075
service = "default"
10671076
runtime = "nodejs10"
10681077
noop_on_destroy = true
1078+
10691079
entrypoint {
10701080
shell = "node ./app.js"
10711081
}

google-beta/iam_iap_app_engine_version_generated_test.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@ resource "google_app_engine_standard_app_version" "version" {
344344
service = "default"
345345
runtime = "nodejs10"
346346
noop_on_destroy = false
347+
347348
entrypoint {
348349
shell = "node ./app.js"
349350
}
@@ -386,6 +387,7 @@ resource "google_app_engine_standard_app_version" "version" {
386387
service = "default"
387388
runtime = "nodejs10"
388389
noop_on_destroy = false
390+
389391
entrypoint {
390392
shell = "node ./app.js"
391393
}
@@ -444,6 +446,7 @@ resource "google_app_engine_standard_app_version" "version" {
444446
service = "default"
445447
runtime = "nodejs10"
446448
noop_on_destroy = false
449+
447450
entrypoint {
448451
shell = "node ./app.js"
449452
}
@@ -488,6 +491,7 @@ resource "google_app_engine_standard_app_version" "version" {
488491
service = "default"
489492
runtime = "nodejs10"
490493
noop_on_destroy = false
494+
491495
entrypoint {
492496
shell = "node ./app.js"
493497
}
@@ -530,6 +534,7 @@ resource "google_app_engine_standard_app_version" "version" {
530534
service = "default"
531535
runtime = "nodejs10"
532536
noop_on_destroy = false
537+
533538
entrypoint {
534539
shell = "node ./app.js"
535540
}
@@ -572,6 +577,7 @@ resource "google_app_engine_standard_app_version" "version" {
572577
service = "default"
573578
runtime = "nodejs10"
574579
noop_on_destroy = false
580+
575581
entrypoint {
576582
shell = "node ./app.js"
577583
}
@@ -619,6 +625,7 @@ resource "google_app_engine_standard_app_version" "version" {
619625
service = "default"
620626
runtime = "nodejs10"
621627
noop_on_destroy = false
628+
622629
entrypoint {
623630
shell = "node ./app.js"
624631
}
@@ -690,6 +697,7 @@ resource "google_app_engine_standard_app_version" "version" {
690697
service = "default"
691698
runtime = "nodejs10"
692699
noop_on_destroy = false
700+
693701
entrypoint {
694702
shell = "node ./app.js"
695703
}
@@ -737,6 +745,7 @@ resource "google_app_engine_standard_app_version" "version" {
737745
service = "default"
738746
runtime = "nodejs10"
739747
noop_on_destroy = false
748+
740749
entrypoint {
741750
shell = "node ./app.js"
742751
}
@@ -808,6 +817,7 @@ resource "google_app_engine_standard_app_version" "version" {
808817
service = "default"
809818
runtime = "nodejs10"
810819
noop_on_destroy = false
820+
811821
entrypoint {
812822
shell = "node ./app.js"
813823
}

google-beta/resource_app_engine_application_url_dispatch_rules_generated_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ resource "google_app_engine_standard_app_version" "admin_v3" {
8888
port = "8080"
8989
}
9090
91-
noop_on_destroy = true
91+
delete_service_on_destroy = true
9292
}
9393
9494
resource "google_storage_bucket" "bucket" {

google-beta/resource_compute_region_network_endpoint_group_generated_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ resource "google_app_engine_flexible_app_version" "appengine_neg" {
235235
}
236236
}
237237
238-
noop_on_destroy = true
238+
delete_service_on_destroy = true
239239
}
240240
241241
resource "google_storage_bucket" "appengine_neg" {

website/docs/r/app_engine_application_url_dispatch_rules.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ resource "google_app_engine_standard_app_version" "admin_v3" {
6868
port = "8080"
6969
}
7070
71-
noop_on_destroy = true
71+
delete_service_on_destroy = true
7272
}
7373
7474
resource "google_storage_bucket" "bucket" {

website/docs/r/compute_region_network_endpoint_group.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ resource "google_app_engine_flexible_app_version" "appengine_neg" {
178178
}
179179
}
180180
181-
noop_on_destroy = true
181+
delete_service_on_destroy = true
182182
}
183183
184184
resource "google_storage_bucket" "appengine_neg" {

0 commit comments

Comments
 (0)