Tests flake due to creation race condition (#3770) (#2292)

modular-magician · web-flow · commit 3b05642f1f12 · 2020-07-22T11:55:53.000-07:00
Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/3770.txt b/.changelog/3770.txt
@@ -0,0 +1,3 @@
+```release-note:none
+
+```
diff --git a/google-beta/resource_google_service_account_iam_test.go b/google-beta/resource_google_service_account_iam_test.go
@@ -57,6 +57,8 @@ func TestAccServiceAccountIamBinding_withCondition(t *testing.T) {
 }
 
 func TestAccServiceAccountIamBinding_withAndWithoutCondition(t *testing.T) {
+	// Resource creation race condition
+	skipIfVcr(t)
 	t.Parallel()
 
 	account := fmt.Sprintf("tf-test-%d", randInt(t))
@@ -137,6 +139,8 @@ func TestAccServiceAccountIamMember_withCondition(t *testing.T) {
 }
 
 func TestAccServiceAccountIamMember_withAndWithoutCondition(t *testing.T) {
+	// Resource creation race condition
+	skipIfVcr(t)
 	t.Parallel()
 
 	account := fmt.Sprintf("tf-test-%d", randInt(t))

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ func TestAccServiceAccountIamBinding_withCondition(t *testing.T) {`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`func TestAccServiceAccountIamBinding_withAndWithoutCondition(t *testing.T) {`
	`60`	`+ // Resource creation race condition`
	`61`	`+ skipIfVcr(t)`
`60`	`62`	`t.Parallel()`
`61`	`63`
`62`	`64`	`account := fmt.Sprintf("tf-test-%d", randInt(t))`
`@@ -137,6 +139,8 @@ func TestAccServiceAccountIamMember_withCondition(t *testing.T) {`
`137`	`139`	`}`
`138`	`140`
`139`	`141`	`func TestAccServiceAccountIamMember_withAndWithoutCondition(t *testing.T) {`
	`142`	`+ // Resource creation race condition`
	`143`	`+ skipIfVcr(t)`
`140`	`144`	`t.Parallel()`
`141`	`145`
`142`	`146`	`account := fmt.Sprintf("tf-test-%d", randInt(t))`