Skip to content

Commit 3fbf18c

Browse files
Ansible - Regional SSL Certs + Health Check (#3210) (#1863)
* done * first try! * copyright * changing examples * removing google provider * test fixes Signed-off-by: Modular Magician <[email protected]>
1 parent 67d4275 commit 3fbf18c

File tree

3 files changed

+21
-12
lines changed

3 files changed

+21
-12
lines changed

.changelog/3210.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:new-resource
2+
`google_compute_region_ssl_certificate`
3+
```

google-beta/resource_compute_region_ssl_certificate_generated_test.go

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,20 +33,25 @@ func TestAccComputeRegionSslCertificate_regionSslCertificateBasicExample(t *test
3333

3434
resource.Test(t, resource.TestCase{
3535
PreCheck: func() { testAccPreCheck(t) },
36-
Providers: testAccProvidersOiCS,
36+
Providers: testAccProviders,
3737
CheckDestroy: testAccCheckComputeRegionSslCertificateDestroy,
3838
Steps: []resource.TestStep{
3939
{
4040
Config: testAccComputeRegionSslCertificate_regionSslCertificateBasicExample(context),
4141
},
42+
{
43+
ResourceName: "google_compute_region_ssl_certificate.default",
44+
ImportState: true,
45+
ImportStateVerify: true,
46+
ImportStateVerifyIgnore: []string{"private_key", "name_prefix"},
47+
},
4248
},
4349
})
4450
}
4551

4652
func testAccComputeRegionSslCertificate_regionSslCertificateBasicExample(context map[string]interface{}) string {
4753
return Nprintf(`
4854
resource "google_compute_region_ssl_certificate" "default" {
49-
provider = google-beta
5055
region = "us-central1"
5156
name_prefix = "my-certificate-"
5257
description = "a description"
@@ -69,12 +74,18 @@ func TestAccComputeRegionSslCertificate_regionSslCertificateRandomProviderExampl
6974

7075
resource.Test(t, resource.TestCase{
7176
PreCheck: func() { testAccPreCheck(t) },
72-
Providers: testAccProvidersOiCS,
77+
Providers: testAccProviders,
7378
CheckDestroy: testAccCheckComputeRegionSslCertificateDestroy,
7479
Steps: []resource.TestStep{
7580
{
7681
Config: testAccComputeRegionSslCertificate_regionSslCertificateRandomProviderExample(context),
7782
},
83+
{
84+
ResourceName: "google_compute_region_ssl_certificate.default",
85+
ImportState: true,
86+
ImportStateVerify: true,
87+
ImportStateVerifyIgnore: []string{"private_key"},
88+
},
7889
},
7990
})
8091
}
@@ -83,7 +94,6 @@ func testAccComputeRegionSslCertificate_regionSslCertificateRandomProviderExampl
8394
return Nprintf(`
8495
# You may also want to control name generation explicitly:
8596
resource "google_compute_region_ssl_certificate" "default" {
86-
provider = google-beta
8797
region = "us-central1"
8898
8999
# The name will contain 8 random hex digits,

website/docs/r/compute_region_ssl_certificate.html.markdown

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ A RegionSslCertificate resource, used for HTTPS load balancing. This resource
2626
provides a mechanism to upload an SSL key and certificate to
2727
the load balancer to serve secure connections from the user.
2828

29-
~> **Warning:** This resource is in beta, and should be used with the terraform-provider-google-beta provider.
30-
See [Provider Versions](https://terraform.io/docs/providers/google/guides/provider_versions.html) for more details on beta resources.
3129

3230
To get more information about RegionSslCertificate, see:
3331

@@ -45,7 +43,6 @@ To get more information about RegionSslCertificate, see:
4543

4644
```hcl
4745
resource "google_compute_region_ssl_certificate" "default" {
48-
provider = google-beta
4946
region = "us-central1"
5047
name_prefix = "my-certificate-"
5148
description = "a description"
@@ -68,7 +65,6 @@ resource "google_compute_region_ssl_certificate" "default" {
6865
```hcl
6966
# You may also want to control name generation explicitly:
7067
resource "google_compute_region_ssl_certificate" "default" {
71-
provider = google-beta
7268
region = "us-central1"
7369
7470
# The name will contain 8 random hex digits,
@@ -250,10 +246,10 @@ This resource provides the following
250246
RegionSslCertificate can be imported using any of these accepted formats:
251247

252248
```
253-
$ terraform import -provider=google-beta google_compute_region_ssl_certificate.default projects/{{project}}/regions/{{region}}/sslCertificates/{{name}}
254-
$ terraform import -provider=google-beta google_compute_region_ssl_certificate.default {{project}}/{{region}}/{{name}}
255-
$ terraform import -provider=google-beta google_compute_region_ssl_certificate.default {{region}}/{{name}}
256-
$ terraform import -provider=google-beta google_compute_region_ssl_certificate.default {{name}}
249+
$ terraform import google_compute_region_ssl_certificate.default projects/{{project}}/regions/{{region}}/sslCertificates/{{name}}
250+
$ terraform import google_compute_region_ssl_certificate.default {{project}}/{{region}}/{{name}}
251+
$ terraform import google_compute_region_ssl_certificate.default {{region}}/{{name}}
252+
$ terraform import google_compute_region_ssl_certificate.default {{name}}
257253
```
258254

259255
-> If you're importing a resource with beta features, make sure to include `-provider=google-beta`

0 commit comments

Comments
 (0)