Skip to content

Commit 423c69a

Browse files
In logging batched requests, use slightly fewer quotes / escapes. (#5308) (#3723)
Fixes hashicorp/terraform-provider-google#7628. Equally clear in the worst case, but less escaping most of the time. Signed-off-by: Modular Magician <[email protected]>
1 parent 33b952c commit 423c69a

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.changelog/5308.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
iam: fixed request batching bug where failed requests would show unnecessary backslash escaping to the user.
3+
```

google-beta/batcher.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@ package google
33
import (
44
"context"
55
"fmt"
6-
"github.com/hashicorp/errwrap"
76
"log"
87
"sync"
98
"time"
9+
10+
"github.com/hashicorp/errwrap"
1011
)
1112

1213
const defaultBatchSendIntervalSec = 3
@@ -177,7 +178,7 @@ func (b *RequestBatcher) SendRequestWithTimeout(batchKey string, request *BatchR
177178
case resp := <-respCh:
178179
if resp.err != nil {
179180
return nil, errwrap.Wrapf(
180-
fmt.Sprintf("Request %q returned error: {{err}}", request.DebugId),
181+
fmt.Sprintf("Request `%s` returned error: {{err}}", request.DebugId),
181182
resp.err)
182183
}
183184
return resp.body, nil

google-beta/resource_iam_member.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ func resourceIamMemberCreate(newUpdaterFunc newResourceIamUpdaterFunc, enableBat
203203
}
204204
if enableBatching {
205205
err = BatchRequestModifyIamPolicy(updater, modifyF, config,
206-
fmt.Sprintf("Create IAM Members %s %+v for %q", memberBind.Role, memberBind.Members[0], updater.DescribeResource()))
206+
fmt.Sprintf("Create IAM Members %s %+v for %s", memberBind.Role, memberBind.Members[0], updater.DescribeResource()))
207207
} else {
208208
err = iamPolicyReadModifyWrite(updater, modifyF)
209209
}

0 commit comments

Comments
 (0)