Adding validation for name attribute in gcs bucket (#6250) (#4532)

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/6250.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+storage: Added name validation for `google_storage_bucket`
+```

google-beta/resource_storage_bucket.go

@@ -401,6 +401,9 @@ func resourceStorageBucketCreate(d *schema.ResourceData, meta interface{}) error
 
 	// Get the bucket and location
 	bucket := d.Get("name").(string)
+	if err := checkGCSName(bucket); err != nil {
+		return err
+	}
 	location := d.Get("location").(string)
 
 	// Create a bucket, setting the labels, location and name.

google-beta/utils.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"log"
 	"os"
+	"regexp"
 	"sort"
 	"strconv"
 	"strings"
@@ -525,3 +526,28 @@ func fake404(reasonResourceType, resourceName string) *googleapi.Error {
 		Message: fmt.Sprintf("%v object %v not found", reasonResourceType, resourceName),
 	}
 }
+
+// validate name of the gcs bucket.
+func checkGCSName(name string) error {
+	MAX_LENGTH := 63
+	var err error
+	for _, str := range strings.Split(name, ".") {
+		strLen := len(str)
+		fmt.Println(str)
+		if strLen > MAX_LENGTH {
+			return fmt.Errorf("error: maximum length exceeded %v\n", str)
+		}
+		valid, _ := regexp.MatchString("^[a-z0-9_]+(-[a-z0-9]+)*$", str)
+		if !valid {
+			return fmt.Errorf("error: string validation failed %v\n", str)
+		}
+		gPrefix := strings.HasPrefix(str, "goog")
+		if gPrefix {
+			return fmt.Errorf("error: string cannot start with %q %v\n", "goog", str)
+		}
+		if err != nil {
+			break
+		}
+	}
+	return nil
+}