Skip to content

Commit 4bacd32

Browse files
fix gke tests (#9691) (#6788)
[upstream:538c6a37f56c229a4944a151765520e9a9837605] Signed-off-by: Modular Magician <[email protected]>
1 parent 9feb45b commit 4bacd32

File tree

4 files changed

+8
-36
lines changed

4 files changed

+8
-36
lines changed

.changelog/9691.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:none
2+
3+
```

.teamcity/components/generated/packages.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ var packages = mapOf(
1212
"displayName" to "Environment Variables",
1313
"path" to "./google-beta/envvar"
1414
),
15+
"fwmodels" to mapOf(
16+
"name" to "fwmodels",
17+
"displayName" to "Framework Models",
18+
"path" to "./google-beta/fwmodels"
19+
),
1520
"fwprovider" to mapOf(
1621
"name" to "fwprovider",
1722
"displayName" to "Framework Provider",

google-beta/services/gkehub/resource_gke_hub_feature_membership_test.go

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,6 @@ func TestAccGKEHubFeatureMembership_gkehubFeatureAcmAllFields(t *testing.T) {
326326
"random_suffix": acctest.RandString(t, 10),
327327
"org_id": envvar.GetTestOrgFromEnv(t),
328328
"billing_account": envvar.GetTestBillingAccountFromEnv(t),
329-
"network_name": acctest.BootstrapSharedTestNetwork(t, "gke-cluster"),
330-
"subnetwork_name": acctest.BootstrapSubnet(t, "gke-cluster", acctest.BootstrapSharedTestNetwork(t, "gke-cluster")),
331329
}
332330

333331
acctest.VcrTest(t, resource.TestCase{
@@ -391,8 +389,6 @@ resource "google_container_cluster" "primary" {
391389
location = "us-central1-a"
392390
initial_node_count = 1
393391
deletion_protection = false
394-
network = "%{network_name}"
395-
subnetwork = "%{subnetwork_name}"
396392
depends_on = [google_project_service.mci, google_project_service.container, google_project_service.container, google_project_service.gkehub]
397393
}
398394
@@ -457,8 +453,6 @@ resource "google_container_cluster" "primary" {
457453
location = "us-central1-a"
458454
initial_node_count = 1
459455
deletion_protection = false
460-
network = "%{network_name}"
461-
subnetwork = "%{subnetwork_name}"
462456
depends_on = [google_project_service.mci, google_project_service.container, google_project_service.container, google_project_service.gkehub]
463457
}
464458
@@ -524,8 +518,6 @@ resource "google_container_cluster" "primary" {
524518
location = "us-central1-a"
525519
initial_node_count = 1
526520
deletion_protection = false
527-
network = "%{network_name}"
528-
subnetwork = "%{subnetwork_name}"
529521
depends_on = [google_project_service.mci, google_project_service.container, google_project_service.container, google_project_service.gkehub, google_project_service.acm]
530522
}
531523
@@ -772,8 +764,6 @@ func TestAccGKEHubFeatureMembership_gkehubFeatureMesh(t *testing.T) {
772764
"random_suffix": acctest.RandString(t, 10),
773765
"org_id": envvar.GetTestOrgFromEnv(t),
774766
"billing_account": envvar.GetTestBillingAccountFromEnv(t),
775-
"network_name": acctest.BootstrapSharedTestNetwork(t, "gke-cluster"),
776-
"subnetwork_name": acctest.BootstrapSubnet(t, "gke-cluster", acctest.BootstrapSharedTestNetwork(t, "gke-cluster")),
777767
}
778768

779769
acctest.VcrTest(t, resource.TestCase{
@@ -826,8 +816,6 @@ resource "google_container_cluster" "primary" {
826816
location = "us-central1-a"
827817
initial_node_count = 1
828818
deletion_protection = false
829-
network = "%{network_name}"
830-
subnetwork = "%{subnetwork_name}"
831819
depends_on = [google_project_service.container, google_project_service.gkehub]
832820
}
833821
@@ -879,8 +867,6 @@ resource "google_container_cluster" "primary" {
879867
location = "us-central1-a"
880868
initial_node_count = 1
881869
deletion_protection = false
882-
network = "%{network_name}"
883-
subnetwork = "%{subnetwork_name}"
884870
depends_on = [google_project_service.container, google_project_service.gkehub]
885871
}
886872
@@ -931,8 +917,6 @@ resource "google_container_cluster" "primary" {
931917
location = "us-central1-a"
932918
initial_node_count = 1
933919
deletion_protection = false
934-
network = "%{network_name}"
935-
subnetwork = "%{subnetwork_name}"
936920
depends_on = [google_project_service.container, google_project_service.gkehub]
937921
}
938922
@@ -983,8 +967,6 @@ resource "google_container_cluster" "primary" {
983967
initial_node_count = 1
984968
project = google_project.project.project_id
985969
deletion_protection = false
986-
network = "%{network_name}"
987-
subnetwork = "%{subnetwork_name}"
988970
depends_on = [google_project_service.container, google_project_service.container, google_project_service.gkehub]
989971
}
990972
@@ -994,8 +976,6 @@ resource "google_container_cluster" "secondary" {
994976
initial_node_count = 1
995977
project = google_project.project.project_id
996978
deletion_protection = false
997-
network = "%{network_name}"
998-
subnetwork = "%{subnetwork_name}"
999979
depends_on = [google_project_service.container, google_project_service.container, google_project_service.gkehub]
1000980
}
1001981
@@ -1005,8 +985,6 @@ resource "google_container_cluster" "tertiary" {
1005985
initial_node_count = 1
1006986
project = google_project.project.project_id
1007987
deletion_protection = false
1008-
network = "%{network_name}"
1009-
subnetwork = "%{subnetwork_name}"
1010988
depends_on = [google_project_service.container, google_project_service.container, google_project_service.gkehub]
1011989
}
1012990
@@ -1017,8 +995,6 @@ resource "google_container_cluster" "quarternary" {
1017995
initial_node_count = 1
1018996
project = google_project.project.project_id
1019997
deletion_protection = false
1020-
network = "%{network_name}"
1021-
subnetwork = "%{subnetwork_name}"
1022998
depends_on = [google_project_service.container, google_project_service.container, google_project_service.gkehub]
1023999
}
10241000
@@ -1085,8 +1061,6 @@ resource "google_container_cluster" "container_acmoci" {
10851061
network = google_compute_network.testnetwork.self_link
10861062
project = google_project.project.project_id
10871063
deletion_protection = false
1088-
network = "%{network_name}"
1089-
subnetwork = "%{subnetwork_name}"
10901064
depends_on = [google_project_service.container, google_project_service.container, google_project_service.gkehub]
10911065
}
10921066

google-beta/services/gkehub2/resource_gke_hub_feature_test.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,6 @@ func TestAccGKEHubFeature_gkehubFeatureMciUpdate(t *testing.T) {
207207
"random_suffix": acctest.RandString(t, 10),
208208
"org_id": envvar.GetTestOrgFromEnv(t),
209209
"billing_account": envvar.GetTestBillingAccountFromEnv(t),
210-
"network_name": acctest.BootstrapSharedTestNetwork(t, "gke-cluster"),
211-
"subnetwork_name": acctest.BootstrapSubnet(t, "gke-cluster", acctest.BootstrapSharedTestNetwork(t, "gke-cluster")),
212210
}
213211

214212
acctest.VcrTest(t, resource.TestCase{
@@ -247,8 +245,6 @@ resource "google_container_cluster" "primary" {
247245
initial_node_count = 1
248246
project = google_project.project.project_id
249247
deletion_protection = false
250-
network = "%{network_name}"
251-
subnetwork = "%{subnetwork_name}"
252248
depends_on = [google_project_service.mci, google_project_service.container, google_project_service.container, google_project_service.gkehub]
253249
}
254250
@@ -258,8 +254,6 @@ resource "google_container_cluster" "secondary" {
258254
initial_node_count = 1
259255
project = google_project.project.project_id
260256
deletion_protection = false
261-
network = "%{network_name}"
262-
subnetwork = "%{subnetwork_name}"
263257
depends_on = [google_project_service.mci, google_project_service.container, google_project_service.container, google_project_service.gkehub]
264258
}
265259
@@ -304,8 +298,6 @@ resource "google_container_cluster" "primary" {
304298
initial_node_count = 1
305299
project = google_project.project.project_id
306300
deletion_protection = false
307-
network = "%{network_name}"
308-
subnetwork = "%{subnetwork_name}"
309301
depends_on = [google_project_service.mci, google_project_service.container, google_project_service.container, google_project_service.gkehub]
310302
}
311303
@@ -315,8 +307,6 @@ resource "google_container_cluster" "secondary" {
315307
initial_node_count = 1
316308
project = google_project.project.project_id
317309
deletion_protection = false
318-
network = "%{network_name}"
319-
subnetwork = "%{subnetwork_name}"
320310
depends_on = [google_project_service.mci, google_project_service.container, google_project_service.container, google_project_service.gkehub]
321311
}
322312

0 commit comments

Comments
 (0)