Skip to content

Commit 5b6185b

Browse files
Fix Cloud Run v2 resources creation failure state inconsistency (#10298) (#7159)
[upstream:28bed1de09cc598290c344eb8af95a63ed34b982] Signed-off-by: Modular Magician <[email protected]>
1 parent 96de289 commit 5b6185b

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.changelog/10298.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
```release-note:bug
2+
cloudrunv2: fixed Terraform state inconsistency when resource `google_cloud_run_v2_job` creation fails
3+
```
4+
```release-note:bug
5+
cloudrunv2: fixed Terraform state inconsistency when resource `google_cloud_run_v2_service` creation fails
6+
```

google-beta/services/cloudrunv2/resource_cloud_run_v2_job.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -865,9 +865,6 @@ func resourceCloudRunV2JobCreate(d *schema.ResourceData, meta interface{}) error
865865
config, res, &opRes, project, "Creating Job", userAgent,
866866
d.Timeout(schema.TimeoutCreate))
867867
if err != nil {
868-
// The resource didn't actually create
869-
d.SetId("")
870-
871868
return fmt.Errorf("Error waiting to create Job: %s", err)
872869
}
873870

google-beta/services/cloudrunv2/resource_cloud_run_v2_service.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1269,9 +1269,6 @@ func resourceCloudRunV2ServiceCreate(d *schema.ResourceData, meta interface{}) e
12691269
config, res, &opRes, project, "Creating Service", userAgent,
12701270
d.Timeout(schema.TimeoutCreate))
12711271
if err != nil {
1272-
// The resource didn't actually create
1273-
d.SetId("")
1274-
12751272
return fmt.Errorf("Error waiting to create Service: %s", err)
12761273
}
12771274

0 commit comments

Comments
 (0)