Skip to content

Commit 6237171

Browse files
Update TestAccGeminiGeminiGcpEnablementSettingBinding_update value (#14207) (#10146)
[upstream:aba3ec93801d76f270a16949cbc543197b6ca8f1] Signed-off-by: Modular Magician <[email protected]>
1 parent 60c5df4 commit 6237171

6 files changed

+14
-17
lines changed

.changelog/14207.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
gemini: removed overly restrictive `product` validation on `google_gemini_gemini_gcp_enablement_setting_binding`, `google_gemini_data_sharing_with_google_setting_binding`. New values like `GOOGLE_CLOUD_ASSIST` will now be accepted.
3+
```

google-beta/services/gemini/resource_gemini_data_sharing_with_google_setting_binding.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import (
3232

3333
"github.com/hashicorp/terraform-provider-google-beta/google-beta/tpgresource"
3434
transport_tpg "github.com/hashicorp/terraform-provider-google-beta/google-beta/transport"
35-
"github.com/hashicorp/terraform-provider-google-beta/google-beta/verify"
3635
)
3736

3837
func ResourceGeminiDataSharingWithGoogleSettingBinding() *schema.Resource {
@@ -91,11 +90,10 @@ Please refer to the field 'effective_labels' for all of the labels present on th
9190
Description: `Resource ID segment making up resource 'name'. It identifies the resource within its parent collection as described in https://google.aip.dev/122.`,
9291
},
9392
"product": {
94-
Type: schema.TypeString,
95-
Computed: true,
96-
Optional: true,
97-
ValidateFunc: verify.ValidateEnum([]string{"GEMINI_CLOUD_ASSIST", ""}),
98-
Description: `Product type of the setting binding. Possible values: ["GEMINI_CLOUD_ASSIST"]`,
93+
Type: schema.TypeString,
94+
Computed: true,
95+
Optional: true,
96+
Description: `Product type of the setting binding. Values include GEMINI_IN_BIGQUERY, GEMINI_CLOUD_ASSIST, etc. See [product reference](https://cloud.google.com/gemini/docs/api/reference/rest/v1/projects.locations.dataSharingWithGoogleSettings.settingBindings) for a complete list.`,
9997
},
10098
"create_time": {
10199
Type: schema.TypeString,

google-beta/services/gemini/resource_gemini_gemini_gcp_enablement_setting_binding.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import (
3232

3333
"github.com/hashicorp/terraform-provider-google-beta/google-beta/tpgresource"
3434
transport_tpg "github.com/hashicorp/terraform-provider-google-beta/google-beta/transport"
35-
"github.com/hashicorp/terraform-provider-google-beta/google-beta/verify"
3635
)
3736

3837
func ResourceGeminiGeminiGcpEnablementSettingBinding() *schema.Resource {
@@ -91,11 +90,10 @@ Please refer to the field 'effective_labels' for all of the labels present on th
9190
Description: `Resource ID segment making up resource 'name'. It identifies the resource within its parent collection as described in https://google.aip.dev/122.`,
9291
},
9392
"product": {
94-
Type: schema.TypeString,
95-
Computed: true,
96-
Optional: true,
97-
ValidateFunc: verify.ValidateEnum([]string{"GEMINI_IN_BIGQUERY", ""}),
98-
Description: `Product type of the setting binding. Possible values: ["GEMINI_IN_BIGQUERY"]`,
93+
Type: schema.TypeString,
94+
Computed: true,
95+
Optional: true,
96+
Description: `Product type of the setting binding. Values include GEMINI_IN_BIGQUERY, GEMINI_CLOUD_ASSIST, etc. See [product reference](https://cloud.google.com/gemini/docs/api/reference/rest/v1/projects.locations.dataSharingWithGoogleSettings.settingBindings) for a complete list.`,
9997
},
10098
"create_time": {
10199
Type: schema.TypeString,

google-beta/services/gemini/resource_gemini_gemini_gcp_enablement_setting_binding_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ resource "google_gemini_gemini_gcp_enablement_setting_binding" "basic_binding" {
106106
location = "global"
107107
target = "projects/${data.google_project.project.number}"
108108
labels = {"my_key" = "my_value"}
109-
product = "GEMINI_IN_BIGQUERY"
109+
product = "GEMINI_CLOUD_ASSIST"
110110
}
111111
`, context)
112112
}

website/docs/r/gemini_data_sharing_with_google_setting_binding.html.markdown

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,7 @@ The following arguments are supported:
7171

7272
* `product` -
7373
(Optional)
74-
Product type of the setting binding.
75-
Possible values are: `GEMINI_CLOUD_ASSIST`.
74+
Product type of the setting binding. Values include GEMINI_IN_BIGQUERY, GEMINI_CLOUD_ASSIST, etc. See [product reference](https://cloud.google.com/gemini/docs/api/reference/rest/v1/projects.locations.dataSharingWithGoogleSettings.settingBindings) for a complete list.
7675

7776
* `labels` -
7877
(Optional)

website/docs/r/gemini_gemini_gcp_enablement_setting_binding.html.markdown

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@ The following arguments are supported:
7777

7878
* `product` -
7979
(Optional)
80-
Product type of the setting binding.
81-
Possible values are: `GEMINI_IN_BIGQUERY`.
80+
Product type of the setting binding. Values include GEMINI_IN_BIGQUERY, GEMINI_CLOUD_ASSIST, etc. See [product reference](https://cloud.google.com/gemini/docs/api/reference/rest/v1/projects.locations.dataSharingWithGoogleSettings.settingBindings) for a complete list.
8281

8382
* `location` -
8483
(Optional)

0 commit comments

Comments
 (0)