Skip to content

Commit 66e5ed1

Browse files
Made nic_type expansion expect a string (#4598) (#3060)
Related to GoogleCloudPlatform/terraform-validator#195 Signed-off-by: Modular Magician <[email protected]>
1 parent 3f3907d commit 66e5ed1

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

.changelog/4598.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:none
2+
3+
```

google-beta/compute_instance_helpers.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -250,19 +250,12 @@ func expandNetworkInterfaces(d TerraformResourceData, config *Config) ([]*comput
250250
Subnetwork: sf.RelativeLink(),
251251
AccessConfigs: expandAccessConfigs(data["access_config"].([]interface{})),
252252
AliasIpRanges: expandAliasIpRanges(data["alias_ip_range"].([]interface{})),
253-
NicType: expandNicType(data["nic_type"].(interface{})),
253+
NicType: data["nic_type"].(string),
254254
}
255255
}
256256
return ifaces, nil
257257
}
258258

259-
func expandNicType(d interface{}) string {
260-
if d == nil {
261-
return ""
262-
}
263-
return d.(string)
264-
}
265-
266259
func flattenServiceAccounts(serviceAccounts []*computeBeta.ServiceAccount) []map[string]interface{} {
267260
result := make([]map[string]interface{}, len(serviceAccounts))
268261
for i, serviceAccount := range serviceAccounts {

0 commit comments

Comments
 (0)