Use connection_name in Cloud Run Sql example (#4391) (#2861)

modular-magician · web-flow · commit 67b9632eadc5 · 2021-01-12T12:51:09.000-08:00
Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/4391.txt b/.changelog/4391.txt
@@ -0,0 +1,3 @@
+```release-note:none
+
+```
diff --git a/google-beta/resource_cloud_run_service_generated_test.go b/google-beta/resource_cloud_run_service_generated_test.go
@@ -78,7 +78,6 @@ func TestAccCloudRunService_cloudRunServiceSqlExample(t *testing.T) {
 	t.Parallel()
 
 	context := map[string]interface{}{
-		"project":             getTestProjectFromEnv(),
 		"deletion_protection": false,
 		"random_suffix":       randString(t, 10),
 	}
@@ -120,7 +119,7 @@ resource "google_cloud_run_service" "default" {
     metadata {
       annotations = {
         "autoscaling.knative.dev/maxScale"      = "1000"
-        "run.googleapis.com/cloudsql-instances" = "%{project}:us-central1:${google_sql_database_instance.instance.name}"
+        "run.googleapis.com/cloudsql-instances" = google_sql_database_instance.instance.connection_name
         "run.googleapis.com/client-name"        = "terraform"
       }
     }
diff --git a/website/docs/r/cloud_run_service.html.markdown b/website/docs/r/cloud_run_service.html.markdown
@@ -94,7 +94,7 @@ resource "google_cloud_run_service" "default" {
     metadata {
       annotations = {
         "autoscaling.knative.dev/maxScale"      = "1000"
-        "run.googleapis.com/cloudsql-instances" = "my-project-name:us-central1:${google_sql_database_instance.instance.name}"
+        "run.googleapis.com/cloudsql-instances" = google_sql_database_instance.instance.connection_name
         "run.googleapis.com/client-name"        = "terraform"
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,6 @@ func TestAccCloudRunService_cloudRunServiceSqlExample(t *testing.T) {`
`78`	`78`	`t.Parallel()`
`79`	`79`
`80`	`80`	`context := map[string]interface{}{`
`81`		`- "project": getTestProjectFromEnv(),`
`82`	`81`	`"deletion_protection": false,`
`83`	`82`	`"random_suffix": randString(t, 10),`
`84`	`83`	`}`
`@@ -120,7 +119,7 @@ resource "google_cloud_run_service" "default" {`
`120`	`119`	`metadata {`
`121`	`120`	`annotations = {`
`122`	`121`	`"autoscaling.knative.dev/maxScale" = "1000"`
`123`		`- "run.googleapis.com/cloudsql-instances" = "%{project}:us-central1:${google_sql_database_instance.instance.name}"`
	`122`	`+ "run.googleapis.com/cloudsql-instances" = google_sql_database_instance.instance.connection_name`
`124`	`123`	`"run.googleapis.com/client-name" = "terraform"`
`125`	`124`	`}`
`126`	`125`	`}`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ resource "google_cloud_run_service" "default" {`
`94`	`94`	`metadata {`
`95`	`95`	`annotations = {`
`96`	`96`	`"autoscaling.knative.dev/maxScale" = "1000"`
`97`		`- "run.googleapis.com/cloudsql-instances" = "my-project-name:us-central1:${google_sql_database_instance.instance.name}"`
	`97`	`+ "run.googleapis.com/cloudsql-instances" = google_sql_database_instance.instance.connection_name`
`98`	`98`	`"run.googleapis.com/client-name" = "terraform"`
`99`	`99`	`}`
`100`	`100`	`}`