Skip to content

Commit 704390d

Browse files
Fix force new on region disk for interface ENUM (#4799) (#3272)
* Fix force new on region disk for interface ENUM * default if empty * make same change to google_compute_disk Signed-off-by: Modular Magician <[email protected]>
1 parent 899a4e3 commit 704390d

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

.changelog/4799.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
compute: fixed issue where `google_compute_region_disk` and `google_compute_disk` would force recreation due to the addition of `interface` property
3+
```

google-beta/resource_compute_disk.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1173,6 +1173,10 @@ func flattenComputeDiskPhysicalBlockSizeBytes(v interface{}, d *schema.ResourceD
11731173
}
11741174

11751175
func flattenComputeDiskInterface(v interface{}, d *schema.ResourceData, config *Config) interface{} {
1176+
if v == nil || isEmptyValue(reflect.ValueOf(v)) {
1177+
return "SCSI"
1178+
}
1179+
11761180
return v
11771181
}
11781182

google-beta/resource_compute_region_disk.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -825,6 +825,10 @@ func flattenComputeRegionDiskType(v interface{}, d *schema.ResourceData, config
825825
}
826826

827827
func flattenComputeRegionDiskInterface(v interface{}, d *schema.ResourceData, config *Config) interface{} {
828+
if v == nil || isEmptyValue(reflect.ValueOf(v)) {
829+
return "SCSI"
830+
}
831+
828832
return v
829833
}
830834

google-beta/resource_dataproc_cluster_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@ import (
1313
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
1414
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
1515

16-
"google.golang.org/api/googleapi"
17-
1816
dataproc "google.golang.org/api/dataproc/v1beta2"
17+
"google.golang.org/api/googleapi"
1918
)
2019

2120
func TestDataprocExtractInitTimeout(t *testing.T) {

0 commit comments

Comments
 (0)