Misc code changes (#4944) (#3404)

modular-magician · web-flow · commit 7387850e0465 · 2021-07-02T10:44:06.000-05:00
* Unnecessary "else" after "return"
* Handle if service account file is missing with proper user message

Signed-off-by: Abhijeet Kasurde &lt;akasurde@redhat.com&gt;
Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/4944.txt b/.changelog/4944.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+ansible: misc fixes for module_utils/gcp_utils.py
+```
diff --git a/google-beta/resource_dataproc_cluster_test.go b/google-beta/resource_dataproc_cluster_test.go
@@ -13,8 +13,9 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 
-	dataproc "google.golang.org/api/dataproc/v1beta2"
 	"google.golang.org/api/googleapi"
+
+	dataproc "google.golang.org/api/dataproc/v1beta2"
 )
 
 func TestDataprocExtractInitTimeout(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+```release-note:enhancement
	`2`	`+ansible: misc fixes for module_utils/gcp_utils.py`
	`3`	+```
Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,9 @@ import (`
`13`	`13`	`"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"`
`14`	`14`	`"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"`
`15`	`15`
`16`		`- dataproc "google.golang.org/api/dataproc/v1beta2"`
`17`	`16`	`"google.golang.org/api/googleapi"`
	`17`	`+`
	`18`	`+ dataproc "google.golang.org/api/dataproc/v1beta2"`
`18`	`19`	`)`
`19`	`20`
`20`	`21`	`func TestDataprocExtractInitTimeout(t *testing.T) {`