Skip to content

Commit 7596e2f

Browse files
fix logging bucket config tests (#4521) (#2981)
Signed-off-by: Modular Magician <[email protected]>
1 parent 17639b7 commit 7596e2f

File tree

5 files changed

+18
-6
lines changed

5 files changed

+18
-6
lines changed

.changelog/4521.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:none
2+
3+
```

google-beta/resource_logging_bucket_config_test.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func TestAccLoggingBucketConfigFolder_basic(t *testing.T) {
3030
ImportStateVerifyIgnore: []string{"folder"},
3131
},
3232
{
33-
Config: testAccLoggingBucketConfigFolder_basic(context, 40),
33+
Config: testAccLoggingBucketConfigFolder_basic(context, 20),
3434
},
3535
{
3636
ResourceName: "google_logging_folder_bucket_config.basic",
@@ -64,6 +64,15 @@ func TestAccLoggingBucketConfigProject_basic(t *testing.T) {
6464
ImportStateVerify: true,
6565
ImportStateVerifyIgnore: []string{"project"},
6666
},
67+
{
68+
Config: testAccLoggingBucketConfigProject_basic(context, 20),
69+
},
70+
{
71+
ResourceName: "google_logging_project_bucket_config.basic",
72+
ImportState: true,
73+
ImportStateVerify: true,
74+
ImportStateVerifyIgnore: []string{"project"},
75+
},
6776
{
6877
Config: testAccLoggingBucketConfigProject_basic(context, 40),
6978
},
@@ -100,7 +109,7 @@ func TestAccLoggingBucketConfigBillingAccount_basic(t *testing.T) {
100109
ImportStateVerifyIgnore: []string{"billing_account"},
101110
},
102111
{
103-
Config: testAccLoggingBucketConfigBillingAccount_basic(context, 40),
112+
Config: testAccLoggingBucketConfigBillingAccount_basic(context, 20),
104113
},
105114
{
106115
ResourceName: "google_logging_billing_account_bucket_config.basic",
@@ -134,7 +143,7 @@ func TestAccLoggingBucketConfigOrganization_basic(t *testing.T) {
134143
ImportStateVerifyIgnore: []string{"organization"},
135144
},
136145
{
137-
Config: testAccLoggingBucketConfigOrganization_basic(context, 40),
146+
Config: testAccLoggingBucketConfigOrganization_basic(context, 20),
138147
},
139148
{
140149
ResourceName: "google_logging_organization_bucket_config.basic",

website/docs/r/logging_billing_account_bucket_config.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ The following arguments are supported:
4242

4343
* `description` - (Optional) Describes this bucket.
4444

45-
* `retention_days` - (Optional) Logs will be retained by default for this amount of time, after which they will automatically be deleted. The minimum retention period is 1 day. If this value is set to zero at bucket creation time, the default time of 30 days will be used.
45+
* `retention_days` - (Optional) Logs will be retained by default for this amount of time, after which they will automatically be deleted. The minimum retention period is 1 day. If this value is set to zero at bucket creation time, the default time of 30 days will be used. Bucket retention can not be increased on buckets outside of projects.
4646

4747
## Attributes Reference
4848

website/docs/r/logging_folder_bucket_config.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ The following arguments are supported:
4343

4444
* `description` - (Optional) Describes this bucket.
4545

46-
* `retention_days` - (Optional) Logs will be retained by default for this amount of time, after which they will automatically be deleted. The minimum retention period is 1 day. If this value is set to zero at bucket creation time, the default time of 30 days will be used.
46+
* `retention_days` - (Optional) Logs will be retained by default for this amount of time, after which they will automatically be deleted. The minimum retention period is 1 day. If this value is set to zero at bucket creation time, the default time of 30 days will be used. Bucket retention can not be increased on buckets outside of projects.
4747

4848
## Attributes Reference
4949

website/docs/r/logging_organization_bucket_config.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ The following arguments are supported:
4242

4343
* `description` - (Optional) Describes this bucket.
4444

45-
* `retention_days` - (Optional) Logs will be retained by default for this amount of time, after which they will automatically be deleted. The minimum retention period is 1 day. If this value is set to zero at bucket creation time, the default time of 30 days will be used.
45+
* `retention_days` - (Optional) Logs will be retained by default for this amount of time, after which they will automatically be deleted. The minimum retention period is 1 day. If this value is set to zero at bucket creation time, the default time of 30 days will be used. Bucket retention can not be increased on buckets outside of projects.
4646

4747
## Attributes Reference
4848

0 commit comments

Comments
 (0)