Added maxUsableWorkstations to workstation Config (#11908) (#8421)

[upstream:a8e718b060267189c83267788e9ae87069295642]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/11908.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+workstations: added `maxUsableWorkstations`  field to `WorkstationConfiguration` resource.
+```

google-beta/services/workstations/iam_workstations_workstation_config_generated_test.go

@@ -194,6 +194,8 @@ resource "google_workstations_workstation_config" "default" {
     "label" = "key"
   }
 
+  max_usable_workstations = 1 
+  
   host {
     gce_instance {
       machine_type                = "e2-standard-4"
@@ -281,6 +283,8 @@ resource "google_workstations_workstation_config" "default" {
     "label" = "key"
   }
 
+  max_usable_workstations = 1 
+  
   host {
     gce_instance {
       machine_type                = "e2-standard-4"
@@ -386,6 +390,8 @@ resource "google_workstations_workstation_config" "default" {
     "label" = "key"
   }
 
+  max_usable_workstations = 1 
+  
   host {
     gce_instance {
       machine_type                = "e2-standard-4"
@@ -476,6 +482,8 @@ resource "google_workstations_workstation_config" "default" {
     "label" = "key"
   }
 
+  max_usable_workstations = 1 
+  
   host {
     gce_instance {
       machine_type                = "e2-standard-4"
@@ -563,6 +571,8 @@ resource "google_workstations_workstation_config" "default" {
     "label" = "key"
   }
 
+  max_usable_workstations = 1 
+  
   host {
     gce_instance {
       machine_type                = "e2-standard-4"

google-beta/services/workstations/resource_workstations_workstation_config.go

@@ -478,6 +478,12 @@ A duration in seconds with up to nine fractional digits, ending with 's'. Exampl
 Please refer to the field 'effective_labels' for all of the labels present on the resource.`,
 				Elem: &schema.Schema{Type: schema.TypeString},
 			},
+			"max_usable_workstations": {
+				Type:        schema.TypeInt,
+				Computed:    true,
+				Optional:    true,
+				Description: `Maximum number of workstations under this configuration a user can have workstations.workstation.use permission on. Only enforced on CreateWorkstation API calls on the user issuing the API request.`,
+			},
 			"persistent_directories": {
 				Type:        schema.TypeList,
 				Computed:    true,
@@ -745,6 +751,12 @@ func resourceWorkstationsWorkstationConfigCreate(d *schema.ResourceData, meta in
 	} else if v, ok := d.GetOkExists("disable_tcp_connections"); !tpgresource.IsEmptyValue(reflect.ValueOf(disableTcpConnectionsProp)) && (ok || !reflect.DeepEqual(v, disableTcpConnectionsProp)) {
 		obj["disableTcpConnections"] = disableTcpConnectionsProp
 	}
+	maxUsableWorkstationsProp, err := expandWorkstationsWorkstationConfigMaxUsableWorkstations(d.Get("max_usable_workstations"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("max_usable_workstations"); !tpgresource.IsEmptyValue(reflect.ValueOf(maxUsableWorkstationsProp)) && (ok || !reflect.DeepEqual(v, maxUsableWorkstationsProp)) {
+		obj["maxUsableWorkstations"] = maxUsableWorkstationsProp
+	}
 	allowedPortsProp, err := expandWorkstationsWorkstationConfigAllowedPorts(d.Get("allowed_ports"), d, config)
 	if err != nil {
 		return err
@@ -916,6 +928,9 @@ func resourceWorkstationsWorkstationConfigRead(d *schema.ResourceData, meta inte
 	if err := d.Set("disable_tcp_connections", flattenWorkstationsWorkstationConfigDisableTcpConnections(res["disableTcpConnections"], d, config)); err != nil {
 		return fmt.Errorf("Error reading WorkstationConfig: %s", err)
 	}
+	if err := d.Set("max_usable_workstations", flattenWorkstationsWorkstationConfigMaxUsableWorkstations(res["maxUsableWorkstations"], d, config)); err != nil {
+		return fmt.Errorf("Error reading WorkstationConfig: %s", err)
+	}
 	if err := d.Set("allowed_ports", flattenWorkstationsWorkstationConfigAllowedPorts(res["allowedPorts"], d, config)); err != nil {
 		return fmt.Errorf("Error reading WorkstationConfig: %s", err)
 	}
@@ -1017,6 +1032,12 @@ func resourceWorkstationsWorkstationConfigUpdate(d *schema.ResourceData, meta in
 	} else if v, ok := d.GetOkExists("disable_tcp_connections"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, disableTcpConnectionsProp)) {
 		obj["disableTcpConnections"] = disableTcpConnectionsProp
 	}
+	maxUsableWorkstationsProp, err := expandWorkstationsWorkstationConfigMaxUsableWorkstations(d.Get("max_usable_workstations"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("max_usable_workstations"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, maxUsableWorkstationsProp)) {
+		obj["maxUsableWorkstations"] = maxUsableWorkstationsProp
+	}
 	allowedPortsProp, err := expandWorkstationsWorkstationConfigAllowedPorts(d.Get("allowed_ports"), d, config)
 	if err != nil {
 		return err
@@ -1107,6 +1128,10 @@ func resourceWorkstationsWorkstationConfigUpdate(d *schema.ResourceData, meta in
 		updateMask = append(updateMask, "disableTcpConnections")
 	}
 
+	if d.HasChange("max_usable_workstations") {
+		updateMask = append(updateMask, "maxUsableWorkstations")
+	}
+
 	if d.HasChange("allowed_ports") {
 		updateMask = append(updateMask, "allowedPorts")
 	}
@@ -1876,6 +1901,23 @@ func flattenWorkstationsWorkstationConfigDisableTcpConnections(v interface{}, d
 	return v
 }
 
+func flattenWorkstationsWorkstationConfigMaxUsableWorkstations(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	// Handles the string fixed64 format
+	if strVal, ok := v.(string); ok {
+		if intVal, err := tpgresource.StringToFixed64(strVal); err == nil {
+			return intVal
+		}
+	}
+
+	// number values are represented as float64
+	if floatVal, ok := v.(float64); ok {
+		intVal := int(floatVal)
+		return intVal
+	}
+
+	return v // let terraform core handle it otherwise
+}
+
 func flattenWorkstationsWorkstationConfigAllowedPorts(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	if v == nil {
 		return v
@@ -2765,6 +2807,10 @@ func expandWorkstationsWorkstationConfigDisableTcpConnections(v interface{}, d t
 	return v, nil
 }
 
+func expandWorkstationsWorkstationConfigMaxUsableWorkstations(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandWorkstationsWorkstationConfigAllowedPorts(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
 	l := v.([]interface{})
 	req := make([]interface{}, 0, len(l))

google-beta/services/workstations/resource_workstations_workstation_config_generated_test.go

@@ -121,6 +121,8 @@ resource "google_workstations_workstation_config" "default" {
     "label" = "key"
   }
 
+  max_usable_workstations = 1 
+  
   host {
     gce_instance {
       machine_type                = "e2-standard-4"

google-beta/services/workstations/resource_workstations_workstation_config_test.go

@@ -811,6 +811,8 @@ resource "google_workstations_workstation_config" "default" {
   labels = {
 	foo = "bar"
   }
+  
+  max_usable_workstations = 2
 
   lifecycle {
     prevent_destroy = true

website/docs/r/workstations_workstation_config.html.markdown

@@ -99,6 +99,8 @@ resource "google_workstations_workstation_config" "default" {
     "label" = "key"
   }
 
+  max_usable_workstations = 1 
+  
   host {
     gce_instance {
       machine_type                = "e2-standard-4"
@@ -744,6 +746,10 @@ The following arguments are supported:
   (Optional)
   Disables support for plain TCP connections in the workstation. By default the service supports TCP connections via a websocket relay. Setting this option to true disables that relay, which prevents the usage of services that require plain tcp connections, such as ssh. When enabled, all communication must occur over https or wss.
 
+* `max_usable_workstations` -
+  (Optional)
+  Maximum number of workstations under this configuration a user can have workstations.workstation.use permission on. Only enforced on CreateWorkstation API calls on the user issuing the API request.
+
 * `allowed_ports` -
   (Optional)
   A list of port ranges specifying single ports or ranges of ports that are externally accessible in the workstation. Allowed ports must be one of 22, 80, or within range 1024-65535. If not specified defaults to ports 22, 80, and ports 1024-65535.