Skip to content

Commit 832121a

Browse files
set required for secret_data (#4627) (#3094)
Signed-off-by: Modular Magician <[email protected]>
1 parent 258c0a3 commit 832121a

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

.changelog/4627.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
secretmanager: Set required on `secrest_data` in `google_secret_manager_secret_version`
3+
```

google-beta/resource_dataproc_cluster_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ import (
1313
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
1414
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
1515

16-
dataproc "google.golang.org/api/dataproc/v1beta2"
1716
"google.golang.org/api/googleapi"
17+
18+
dataproc "google.golang.org/api/dataproc/v1beta2"
1819
)
1920

2021
func TestDataprocExtractInitTimeout(t *testing.T) {

google-beta/resource_secret_manager_secret_version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func resourceSecretManagerSecretVersion() *schema.Resource {
5858
Schema: map[string]*schema.Schema{
5959
"secret_data": {
6060
Type: schema.TypeString,
61-
Optional: true,
61+
Required: true,
6262
ForceNew: true,
6363
Description: `The secret data. Must be no larger than 64KiB.`,
6464
Sensitive: true,

website/docs/r/secret_manager_secret_version.html.markdown

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,11 @@ resource "google_secret_manager_secret_version" "secret-version-basic" {
6363
The following arguments are supported:
6464

6565

66+
* `secret_data` -
67+
(Required)
68+
The secret data. Must be no larger than 64KiB.
69+
**Note**: This property is sensitive and will not be displayed in the plan.
70+
6671
* `secret` -
6772
(Required)
6873
Secret Manager secret resource
@@ -75,11 +80,6 @@ The following arguments are supported:
7580
(Optional)
7681
The current state of the SecretVersion.
7782

78-
* `secret_data` -
79-
(Optional)
80-
The secret data. Must be no larger than 64KiB.
81-
**Note**: This property is sensitive and will not be displayed in the plan.
82-
8383

8484
## Attributes Reference
8585

0 commit comments

Comments
 (0)