Handle compute instance not found crash (#5955) (#4262)

modular-magician · web-flow · commit 83a40bd5ec4e · 2022-04-27T14:36:25.000-07:00
Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/5955.txt b/.changelog/5955.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+compute: fixed a crash when `compute.instance` is not found
+```
diff --git a/google-beta/resource_compute_instance.go b/google-beta/resource_compute_instance.go
@@ -1419,7 +1419,7 @@ func resourceComputeInstanceUpdate(d *schema.ResourceData, meta interface{}) err
 	// Change back to getInstance(config, d) once updating alias ips is GA.
 	instance, err := config.NewComputeClient(userAgent).Instances.Get(project, zone, d.Get("name").(string)).Do()
 	if err != nil {
-		return handleNotFoundError(err, d, fmt.Sprintf("Instance %s", instance.Name))
+		return handleNotFoundError(err, d, fmt.Sprintf("Instance %s", d.Get("name").(string)))
 	}
 
 	// Enable partial mode for the resource since it is possible

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+```release-note:bug
	`2`	+compute: fixed a crash when `compute.instance` is not found
	`3`	+```
Original file line number	Diff line number	Diff line change
`@@ -1419,7 +1419,7 @@ func resourceComputeInstanceUpdate(d *schema.ResourceData, meta interface{}) err`
`1419`	`1419`	`// Change back to getInstance(config, d) once updating alias ips is GA.`
`1420`	`1420`	`instance, err := config.NewComputeClient(userAgent).Instances.Get(project, zone, d.Get("name").(string)).Do()`
`1421`	`1421`	`if err != nil {`
`1422`		`- return handleNotFoundError(err, d, fmt.Sprintf("Instance %s", instance.Name))`
	`1422`	`+ return handleNotFoundError(err, d, fmt.Sprintf("Instance %s", d.Get("name").(string)))`
`1423`	`1423`	`}`
`1424`	`1424`
`1425`	`1425`	`// Enable partial mode for the resource since it is possible`