change product to be inferred from the dcl product title in the function names/documentation/resource name (#4942) (#3402)

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/4942.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

google-beta/provider_dcl_client_creation.go

@@ -23,7 +23,7 @@ import (
 	gke_hub "github.com/GoogleCloudPlatform/declarative-resource-client-library/services/google/gkehub/beta"
 )
 
-func NewDCLCloudBuildClient(config *Config, userAgent, billingProject string) *cloudbuild.Client {
+func NewDCLCloudbuildClient(config *Config, userAgent, billingProject string) *cloudbuild.Client {
 	dclClientOptions := dcl.WithHTTPClient(config.client)
 	dclUserAgentOptions := dcl.WithUserAgent(userAgent)
 	dclLoggerOptions := dcl.WithLogger(dclLogger{})

google-beta/resource_cloudbuild_worker_pool.go

@@ -180,7 +180,7 @@ func resourceCloudbuildWorkerPoolCreate(d *schema.ResourceData, meta interface{}
 	if bp, err := getBillingProject(d, config); err == nil {
 		billingProject = bp
 	}
-	client := NewDCLCloudBuildClient(config, userAgent, billingProject)
+	client := NewDCLCloudbuildClient(config, userAgent, billingProject)
 	res, err := client.ApplyWorkerPool(context.Background(), obj, createDirective...)
 	if err != nil {
 		// The resource didn't actually create
@@ -217,7 +217,7 @@ func resourceCloudbuildWorkerPoolRead(d *schema.ResourceData, meta interface{})
 	if bp, err := getBillingProject(d, config); err == nil {
 		billingProject = bp
 	}
-	client := NewDCLCloudBuildClient(config, userAgent, billingProject)
+	client := NewDCLCloudbuildClient(config, userAgent, billingProject)
 	res, err := client.GetWorkerPool(context.Background(), obj)
 	if err != nil {
 		// Resource not found
@@ -279,7 +279,7 @@ func resourceCloudbuildWorkerPoolUpdate(d *schema.ResourceData, meta interface{}
 	if bp, err := getBillingProject(d, config); err == nil {
 		billingProject = bp
 	}
-	client := NewDCLCloudBuildClient(config, userAgent, billingProject)
+	client := NewDCLCloudbuildClient(config, userAgent, billingProject)
 	res, err := client.ApplyWorkerPool(context.Background(), obj, directive...)
 	if err != nil {
 		return fmt.Errorf("Error updating WorkerPool: %s", err)
@@ -315,7 +315,7 @@ func resourceCloudbuildWorkerPoolDelete(d *schema.ResourceData, meta interface{}
 	if bp, err := getBillingProject(d, config); err == nil {
 		billingProject = bp
 	}
-	client := NewDCLCloudBuildClient(config, userAgent, billingProject)
+	client := NewDCLCloudbuildClient(config, userAgent, billingProject)
 	if err := client.DeleteWorkerPool(context.Background(), obj); err != nil {
 		return fmt.Errorf("Error deleting WorkerPool: %s", err)
 	}

google-beta/resource_cloudbuild_worker_pool_sweeper_test.go

@@ -10,14 +10,14 @@ import (
 )
 
 func init() {
-	resource.AddTestSweepers("CloudBuildWorker_pool", &resource.Sweeper{
-		Name: "CloudBuildWorker_pool",
-		F:    testSweepCloudBuildWorker_pool,
+	resource.AddTestSweepers("CloudbuildWorker_pool", &resource.Sweeper{
+		Name: "CloudbuildWorker_pool",
+		F:    testSweepCloudbuildWorker_pool,
 	})
 }
 
-func testSweepCloudBuildWorker_pool(region string) error {
-	resourceName := "CloudBuildWorker_pool"
+func testSweepCloudbuildWorker_pool(region string) error {
+	resourceName := "CloudbuildWorker_pool"
 	log.Printf("[INFO][SWEEPER_LOG] Starting sweeper for %s", resourceName)
 
 	config, err := sharedConfigForRegion(region)
@@ -44,14 +44,14 @@ func testSweepCloudBuildWorker_pool(region string) error {
 		"billing_account": billingId,
 	}
 
-	client := NewDCLCloudBuildClient(config, config.userAgent, "")
-	err = client.DeleteAllWorkerPool(context.Background(), d["project"], d["location"], isDeletableCloudBuildWorker_pool)
+	client := NewDCLCloudbuildClient(config, config.userAgent, "")
+	err = client.DeleteAllWorkerPool(context.Background(), d["project"], d["location"], isDeletableCloudbuildWorker_pool)
 	if err != nil {
 		return err
 	}
 	return nil
 }
 
-func isDeletableCloudBuildWorker_pool(r *cloudbuild.WorkerPool) bool {
+func isDeletableCloudbuildWorker_pool(r *cloudbuild.WorkerPool) bool {
 	return isSweepableTestResource(*r.Name)
 }

google-beta/resource_gke_hub_feature_membership_test.go

@@ -5,7 +5,7 @@ import (
 	"fmt"
 	"testing"
 
-	"github.com/GoogleCloudPlatform/declarative-resource-client-library/dcl"
+	dcl "github.com/GoogleCloudPlatform/declarative-resource-client-library/dcl"
 	gkehub "github.com/GoogleCloudPlatform/declarative-resource-client-library/services/google/gkehub/beta"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"