add update_mask_fields to healthcare_hl7_v2_store parser_config (#5122) (#3560)

* add update_mask_fields to healthcare_hl7_v2_store parser_config

* make parser_config default from api

* add tests

* make test changes beta-only

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/5122.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+healthcare: fixed bug where changes to `google_healthcare_hl7_v2_store.parser_config` subfields would error with '...parser_config.version field is immutable...`
+```

google-beta/resource_healthcare_hl7_v2_store.go

@@ -139,6 +139,7 @@ Fields/functions available for filtering are:
 			},
 			"parser_config": {
 				Type:        schema.TypeList,
+				Computed:    true,
 				Optional:    true,
 				Description: `A nested object resource`,
 				MaxItems:    1,
@@ -357,7 +358,9 @@ func resourceHealthcareHl7V2StoreUpdate(d *schema.ResourceData, meta interface{}
 	updateMask := []string{}
 
 	if d.HasChange("parser_config") {
-		updateMask = append(updateMask, "parserConfig")
+		updateMask = append(updateMask, "parser_config.allow_null_header",
+			"parser_config.segment_terminator",
+			"parser_config.schema")
 	}
 
 	if d.HasChange("labels") {

google-beta/resource_healthcare_hl7_v2_store_test.go

@@ -113,6 +113,38 @@ func TestAccHealthcareHl7V2Store_basic(t *testing.T) {
 	})
 }
 
+func TestAccHealthcareHl7V2Store_updateSchema(t *testing.T) {
+	t.Parallel()
+
+	datasetName := fmt.Sprintf("tf-test-dataset-%s", randString(t, 10))
+	hl7_v2StoreName := fmt.Sprintf("tf-test-hl7_v2-store-%s", randString(t, 10))
+	resourceName := "google_healthcare_hl7_v2_store.default"
+
+	vcrTest(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
+		CheckDestroy: testAccCheckHealthcareHl7V2StoreDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testGoogleHealthcareHl7V2Store_basicSchema(hl7_v2StoreName, datasetName),
+			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+			{
+				Config: testGoogleHealthcareHl7V2Store_updateSchema(hl7_v2StoreName, datasetName),
+			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 func testGoogleHealthcareHl7V2Store_basic(hl7_v2StoreName, datasetName string) string {
 	return fmt.Sprintf(`
 resource "google_healthcare_hl7_v2_store" "default" {
@@ -158,6 +190,59 @@ resource "google_pubsub_topic" "topic" {
 `, hl7_v2StoreName, datasetName, pubsubTopic)
 }
 
+func testGoogleHealthcareHl7V2Store_basicSchema(hl7_v2StoreName, datasetName string) string {
+	return fmt.Sprintf(`
+resource "google_healthcare_hl7_v2_store" "default" {
+  provider = google-beta
+  name     = "%s"
+  dataset  = google_healthcare_dataset.dataset.id
+
+  parser_config {
+    schema  = <<EOF
+          {
+            "schematizedParsingType": "SOFT_FAIL",
+            "ignoreMinOccurs": true
+          }
+        EOF
+    version = "V2"
+  }
+}
+
+resource "google_healthcare_dataset" "dataset" {
+  provider = google-beta
+  name     = "%s"
+  location = "us-central1"
+}
+`, hl7_v2StoreName, datasetName)
+}
+
+func testGoogleHealthcareHl7V2Store_updateSchema(hl7_v2StoreName, datasetName string) string {
+	return fmt.Sprintf(`
+resource "google_healthcare_hl7_v2_store" "default" {
+  provider = google-beta
+  name     = "%s"
+  dataset  = google_healthcare_dataset.dataset.id
+
+  parser_config {
+    schema  = <<EOF
+          {
+            "schematizedParsingType": "SOFT_FAIL",
+            "ignoreMinOccurs": true,
+            "unexpectedSegmentHandling": "PARSE"
+          }
+        EOF
+    version = "V2"
+  }
+}
+
+resource "google_healthcare_dataset" "dataset" {
+  provider = google-beta
+  name     = "%s"
+  location = "us-central1"
+}
+`, hl7_v2StoreName, datasetName)
+}
+
 func testAccCheckGoogleHealthcareHl7V2StoreUpdate(t *testing.T, pubsubTopic string) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		var foundResource = false