Add Bidirectional Snapmirror fields to Volume and Replication (#15217) (#10813)

[upstream:9b164195983786204ba7eb28a73e50f9322b8082]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/15217.txt

@@ -0,0 +1,6 @@
+```release-note:enhancement
+netapp: added additional fields `replication_schedule`, `hybrid_replication_type`, `large_volume_constituent_count`  to `hybrid_replication_parameters` field in `google_netapp_volume` resource
+```
+```release-note:enhancement
+netapp: added `hybrid_replication_user_commands` field  with subfield `commands` to `google_netapp_volume_replication` resource
+```

google-beta/services/netapp/resource_netapp_volume.go

@@ -235,13 +235,24 @@ Format: 'projects/{{projectId}}/locations/{{location}}/backupVaults/{{backupVaul
 							Optional:    true,
 							Description: `Optional. Description of the replication.`,
 						},
+						"hybrid_replication_type": {
+							Type:         schema.TypeString,
+							Optional:     true,
+							ValidateFunc: verify.ValidateEnum([]string{"MIGRATION", "CONTINUOUS_REPLICATION", "ONPREM_REPLICATION", "REVERSE_ONPREM_REPLICATION", ""}),
+							Description:  `Optional. Type of the volume's hybrid replication. Possible values: ["MIGRATION", "CONTINUOUS_REPLICATION", "ONPREM_REPLICATION", "REVERSE_ONPREM_REPLICATION"]`,
+						},
 						"labels": {
 							Type:     schema.TypeMap,
 							Optional: true,
 							Description: `Optional. Labels to be added to the replication as the key value pairs.
 An object containing a list of "key": value pairs. Example: { "name": "wrench", "mass": "1.3kg", "count": "3" }.`,
 							Elem: &schema.Schema{Type: schema.TypeString},
 						},
+						"large_volume_constituent_count": {
+							Type:        schema.TypeInt,
+							Optional:    true,
+							Description: `Optional. Constituent volume count for large volume.`,
+						},
 						"peer_cluster_name": {
 							Type:        schema.TypeString,
 							Optional:    true,
@@ -270,6 +281,12 @@ An object containing a list of "key": value pairs. Example: { "name": "wrench",
 							Optional:    true,
 							Description: `Required. Desired name for the replication of this volume.`,
 						},
+						"replication_schedule": {
+							Type:         schema.TypeString,
+							Optional:     true,
+							ValidateFunc: verify.ValidateEnum([]string{"EVERY_10_MINUTES", "HOURLY", "DAILY", ""}),
+							Description:  `Optional. Replication Schedule for the replication created. Possible values: ["EVERY_10_MINUTES", "HOURLY", "DAILY"]`,
+						},
 					},
 				},
 			},
@@ -2018,6 +2035,12 @@ func flattenNetappVolumeHybridReplicationParameters(v interface{}, d *schema.Res
 		flattenNetappVolumeHybridReplicationParametersDescription(original["description"], d, config)
 	transformed["labels"] =
 		flattenNetappVolumeHybridReplicationParametersLabels(original["labels"], d, config)
+	transformed["replication_schedule"] =
+		flattenNetappVolumeHybridReplicationParametersReplicationSchedule(original["replicationSchedule"], d, config)
+	transformed["hybrid_replication_type"] =
+		flattenNetappVolumeHybridReplicationParametersHybridReplicationType(original["hybridReplicationType"], d, config)
+	transformed["large_volume_constituent_count"] =
+		flattenNetappVolumeHybridReplicationParametersLargeVolumeConstituentCount(original["largeVolumeConstituentCount"], d, config)
 	return []interface{}{transformed}
 }
 func flattenNetappVolumeHybridReplicationParametersReplication(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
@@ -2052,6 +2075,31 @@ func flattenNetappVolumeHybridReplicationParametersLabels(v interface{}, d *sche
 	return v
 }
 
+func flattenNetappVolumeHybridReplicationParametersReplicationSchedule(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	return v
+}
+
+func flattenNetappVolumeHybridReplicationParametersHybridReplicationType(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	return v
+}
+
+func flattenNetappVolumeHybridReplicationParametersLargeVolumeConstituentCount(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	// Handles the string fixed64 format
+	if strVal, ok := v.(string); ok {
+		if intVal, err := tpgresource.StringToFixed64(strVal); err == nil {
+			return intVal
+		}
+	}
+
+	// number values are represented as float64
+	if floatVal, ok := v.(float64); ok {
+		intVal := int(floatVal)
+		return intVal
+	}
+
+	return v // let terraform core handle it otherwise
+}
+
 func flattenNetappVolumeThroughputMibps(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	return v
 }
@@ -2772,6 +2820,27 @@ func expandNetappVolumeHybridReplicationParameters(v interface{}, d tpgresource.
 		transformed["labels"] = transformedLabels
 	}
 
+	transformedReplicationSchedule, err := expandNetappVolumeHybridReplicationParametersReplicationSchedule(original["replication_schedule"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedReplicationSchedule); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["replicationSchedule"] = transformedReplicationSchedule
+	}
+
+	transformedHybridReplicationType, err := expandNetappVolumeHybridReplicationParametersHybridReplicationType(original["hybrid_replication_type"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedHybridReplicationType); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["hybridReplicationType"] = transformedHybridReplicationType
+	}
+
+	transformedLargeVolumeConstituentCount, err := expandNetappVolumeHybridReplicationParametersLargeVolumeConstituentCount(original["large_volume_constituent_count"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedLargeVolumeConstituentCount); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["largeVolumeConstituentCount"] = transformedLargeVolumeConstituentCount
+	}
+
 	return transformed, nil
 }
 
@@ -2814,6 +2883,18 @@ func expandNetappVolumeHybridReplicationParametersLabels(v interface{}, d tpgres
 	return m, nil
 }
 
+func expandNetappVolumeHybridReplicationParametersReplicationSchedule(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
+func expandNetappVolumeHybridReplicationParametersHybridReplicationType(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
+func expandNetappVolumeHybridReplicationParametersLargeVolumeConstituentCount(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandNetappVolumeThroughputMibps(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
 	return v, nil
 }

google-beta/services/netapp/resource_netapp_volume_generated_meta.yaml

@@ -35,12 +35,15 @@ fields:
   - field: 'hot_tier_size_used_gib'
   - field: 'hybrid_replication_parameters.cluster_location'
   - field: 'hybrid_replication_parameters.description'
+  - field: 'hybrid_replication_parameters.hybrid_replication_type'
   - field: 'hybrid_replication_parameters.labels'
+  - field: 'hybrid_replication_parameters.large_volume_constituent_count'
   - field: 'hybrid_replication_parameters.peer_cluster_name'
   - field: 'hybrid_replication_parameters.peer_ip_addresses'
   - field: 'hybrid_replication_parameters.peer_svm_name'
   - field: 'hybrid_replication_parameters.peer_volume_name'
   - field: 'hybrid_replication_parameters.replication'
+  - field: 'hybrid_replication_parameters.replication_schedule'
   - field: 'kerberos_enabled'
   - field: 'kms_config'
   - field: 'labels'

google-beta/services/netapp/resource_netapp_volume_replication.go

@@ -281,6 +281,23 @@ Uses RFC 3339, where generated output will always be Z-normalized and uses 0, 3,
 				Computed:    true,
 				Description: `Hybrid replication type.`,
 			},
+			"hybrid_replication_user_commands": {
+				Type:        schema.TypeList,
+				Computed:    true,
+				Description: `Copy pastable snapmirror commands to be executed on onprem cluster by the customer.`,
+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						"commands": {
+							Type:        schema.TypeList,
+							Computed:    true,
+							Description: `List of commands to be executed by the customer.`,
+							Elem: &schema.Schema{
+								Type: schema.TypeString,
+							},
+						},
+					},
+				},
+			},
 			"mirror_state": {
 				Type:     schema.TypeString,
 				Computed: true,
@@ -620,6 +637,9 @@ func resourceNetappVolumeReplicationRead(d *schema.ResourceData, meta interface{
 	if err := d.Set("hybrid_peering_details", flattenNetappVolumeReplicationHybridPeeringDetails(res["hybridPeeringDetails"], d, config)); err != nil {
 		return fmt.Errorf("Error reading VolumeReplication: %s", err)
 	}
+	if err := d.Set("hybrid_replication_user_commands", flattenNetappVolumeReplicationHybridReplicationUserCommands(res["hybridReplicationUserCommands"], d, config)); err != nil {
+		return fmt.Errorf("Error reading VolumeReplication: %s", err)
+	}
 	if err := d.Set("terraform_labels", flattenNetappVolumeReplicationTerraformLabels(res["labels"], d, config)); err != nil {
 		return fmt.Errorf("Error reading VolumeReplication: %s", err)
 	}
@@ -1172,6 +1192,23 @@ func flattenNetappVolumeReplicationHybridPeeringDetailsPeerSvmName(v interface{}
 	return v
 }
 
+func flattenNetappVolumeReplicationHybridReplicationUserCommands(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	if v == nil {
+		return nil
+	}
+	original := v.(map[string]interface{})
+	if len(original) == 0 {
+		return nil
+	}
+	transformed := make(map[string]interface{})
+	transformed["commands"] =
+		flattenNetappVolumeReplicationHybridReplicationUserCommandsCommands(original["commands"], d, config)
+	return []interface{}{transformed}
+}
+func flattenNetappVolumeReplicationHybridReplicationUserCommandsCommands(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	return v
+}
+
 func flattenNetappVolumeReplicationTerraformLabels(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	if v == nil {
 		return v

google-beta/services/netapp/resource_netapp_volume_replication_generated_meta.yaml

@@ -29,6 +29,7 @@ fields:
   - field: 'hybrid_peering_details.peer_volume_name'
   - field: 'hybrid_peering_details.subnet_ip'
   - field: 'hybrid_replication_type'
+  - field: 'hybrid_replication_user_commands.commands'
   - field: 'labels'
   - field: 'location'
     provider_only: true

website/docs/r/netapp_volume.html.markdown

@@ -425,6 +425,20 @@ Possible values: DEFAULT, FORCE.
   Optional. Labels to be added to the replication as the key value pairs.
   An object containing a list of "key": value pairs. Example: { "name": "wrench", "mass": "1.3kg", "count": "3" }.
 
+* `replication_schedule` -
+  (Optional)
+  Optional. Replication Schedule for the replication created.
+  Possible values are: `EVERY_10_MINUTES`, `HOURLY`, `DAILY`.
+
+* `hybrid_replication_type` -
+  (Optional)
+  Optional. Type of the volume's hybrid replication.
+  Possible values are: `MIGRATION`, `CONTINUOUS_REPLICATION`, `ONPREM_REPLICATION`, `REVERSE_ONPREM_REPLICATION`.
+
+* `large_volume_constituent_count` -
+  (Optional)
+  Optional. Constituent volume count for large volume.
+
 ## Attributes Reference
 
 In addition to the arguments listed above, the following computed attributes are exported:

website/docs/r/netapp_volume_replication.html.markdown

@@ -263,6 +263,10 @@ In addition to the arguments listed above, the following computed attributes are
   HybridPeeringDetails contains details about the hybrid peering.
   Structure is [documented below](#nested_hybrid_peering_details).
 
+* `hybrid_replication_user_commands` -
+  Copy pastable snapmirror commands to be executed on onprem cluster by the customer.
+  Structure is [documented below](#nested_hybrid_replication_user_commands).
+
 * `terraform_labels` -
   The combination of labels configured directly on the resource
    and default labels configured on the provider.
@@ -338,6 +342,12 @@ In addition to the arguments listed above, the following computed attributes are
   (Output)
   Optional. Name of the user's local source vserver svm to be peered with the destination vserver svm.
 
+<a name="nested_hybrid_replication_user_commands"></a>The `hybrid_replication_user_commands` block contains:
+
+* `commands` -
+  (Output)
+  List of commands to be executed by the customer.
+
 ## Timeouts
 
 This resource provides the following