fix deleting monitoring dashboards (#4064) (#2558)

modular-magician · danawillow · commit 8f9bed0884c8 · 2020-10-09T10:45:23.000-07:00
Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/4064.txt b/.changelog/4064.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+monitoring: fixed bug where deleting a `google_monitoring_dashboard` would give an "unsupported protocol scheme" error
+```
diff --git a/google-beta/resource_monitoring_dashboard.go b/google-beta/resource_monitoring_dashboard.go
@@ -187,7 +187,7 @@ func resourceMonitoringDashboardDelete(d *schema.ResourceData, meta interface{})
 		return err
 	}
 
-	_, err = sendRequestWithTimeout(config, "DELETE", project, userAgent, url, nil, d.Timeout(schema.TimeoutDelete), isMonitoringConcurrentEditError)
+	_, err = sendRequestWithTimeout(config, "DELETE", project, url, userAgent, nil, d.Timeout(schema.TimeoutDelete), isMonitoringConcurrentEditError)
 	if err != nil {
 		return handleNotFoundError(err, d, fmt.Sprintf("MonitoringDashboard %q", d.Id()))
 	}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+```release-note:bug
	`2`	+monitoring: fixed bug where deleting a `google_monitoring_dashboard` would give an "unsupported protocol scheme" error
	`3`	+```
Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ func resourceMonitoringDashboardDelete(d *schema.ResourceData, meta interface{})`
`187`	`187`	`return err`
`188`	`188`	`}`
`189`	`189`
`190`		`- _, err = sendRequestWithTimeout(config, "DELETE", project, userAgent, url, nil, d.Timeout(schema.TimeoutDelete), isMonitoringConcurrentEditError)`
	`190`	`+ _, err = sendRequestWithTimeout(config, "DELETE", project, url, userAgent, nil, d.Timeout(schema.TimeoutDelete), isMonitoringConcurrentEditError)`
`191`	`191`	`if err != nil {`
`192`	`192`	`return handleNotFoundError(err, d, fmt.Sprintf("MonitoringDashboard %q", d.Id()))`
`193`	`193`	`}`