Deprecate liveness_probe.tcp_socket field from google_cloud_run_v2_service (#7158) (#5128)

Signed-off-by: Modular Magician <[email protected]>

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/7158.txt

@@ -0,0 +1,3 @@
+```release-note:deprecation
+cloudrunv2: deprecated `liveness_probe.tcp_socket` field from `google_cloud_run_v2_service` resource as it is not supported by the API and it will be removed in a future major release
+```

google-beta/resource_cloud_run_v2_service.go

@@ -153,7 +153,7 @@ func resourceCloudRunV2Service() *schema.Resource {
 												"http_get": {
 													Type:        schema.TypeList,
 													Optional:    true,
-													Description: `HTTPGet specifies the http request to perform. Exactly one of HTTPGet or TCPSocket must be specified.`,
+													Description: `HTTPGet specifies the http request to perform.`,
 													MaxItems:    1,
 													Elem: &schema.Resource{
 														Schema: map[string]*schema.Schema{
@@ -201,7 +201,8 @@ func resourceCloudRunV2Service() *schema.Resource {
 												"tcp_socket": {
 													Type:        schema.TypeList,
 													Optional:    true,
-													Description: `TCPSocket specifies an action involving a TCP port. Exactly one of HTTPGet or TCPSocket must be specified.`,
+													Deprecated:  "Cloud Run does not support tcp socket in liveness probe and `liveness_probe.tcp_socket` field will be removed in a future major release.",
+													Description: `TCPSocket specifies an action involving a TCP port. This field is not supported in liveness probe currently.`,
 													MaxItems:    1,
 													Elem: &schema.Resource{
 														Schema: map[string]*schema.Schema{

google-beta/resource_cloud_run_v2_service_test.go

@@ -229,15 +229,6 @@ func TestAccCloudRunV2Service_cloudrunv2ServiceProbesUpdate(t *testing.T) {
 				ImportStateVerify:       true,
 				ImportStateVerifyIgnore: []string{"name", "location"},
 			},
-			{
-				Config: testAccCloudRunV2Service_cloudrunv2ServiceUpdateWithHTTPStartupProbeAndTCPLivenessProbe(context),
-			},
-			{
-				ResourceName:            "google_cloud_run_v2_service.default",
-				ImportState:             true,
-				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"name", "location"},
-			},
 			{
 				Config: testAccCloudRunV2Service_cloudrunv2ServiceUpdateWithEmptyHTTPStartupProbe(context),
 			},
@@ -327,49 +318,6 @@ resource "google_cloud_run_v2_service" "default" {
 `, context)
 }
 
-func testAccCloudRunV2Service_cloudrunv2ServiceUpdateWithHTTPStartupProbeAndTCPLivenessProbe(context map[string]interface{}) string {
-	return Nprintf(`
-resource "google_cloud_run_v2_service" "default" {
-  name     = "tf-test-cloudrun-service%{random_suffix}"
-  location = "us-central1"
-  
-  template {
-    containers {
-      image = "us-docker.pkg.dev/cloudrun/container/hello"
-      ports {
-        container_port = 8080
-      }
-      startup_probe {
-        initial_delay_seconds = 3
-        period_seconds = 2
-        timeout_seconds = 6
-        failure_threshold = 3
-        http_get {
-          path = "/some-path"
-          http_headers {
-            name = "User-Agent"
-            value = "magic-modules"
-          }
-          http_headers {
-            name = "Some-Name"
-          }
-        }
-      }
-      liveness_probe {
-        initial_delay_seconds = 3
-        period_seconds = 2
-        timeout_seconds = 6
-        failure_threshold = 3
-        tcp_socket {
-          port = 8080
-        }
-      }
-    }
-  }
-}
-`, context)
-}
-
 func testAccCloudRunV2Service_cloudrunv2ServiceUpdateWithEmptyHTTPStartupProbe(context map[string]interface{}) string {
 	return Nprintf(`
 resource "google_cloud_run_v2_service" "default" {
@@ -398,6 +346,10 @@ resource "google_cloud_run_v2_service" "default" {
     containers {
       image = "us-docker.pkg.dev/cloudrun/container/hello"
       startup_probe {
+        initial_delay_seconds = 3
+        period_seconds = 2
+        timeout_seconds = 6
+        failure_threshold = 3
         http_get {
           path = "/some-path"
           http_headers {

website/docs/r/cloud_run_v2_service.html.markdown

@@ -510,12 +510,12 @@ The following arguments are supported:
 
 * `http_get` -
   (Optional)
-  HTTPGet specifies the http request to perform. Exactly one of HTTPGet or TCPSocket must be specified.
+  HTTPGet specifies the http request to perform.
   Structure is [documented below](#nested_http_get).
 
 * `tcp_socket` -
-  (Optional)
-  TCPSocket specifies an action involving a TCP port. Exactly one of HTTPGet or TCPSocket must be specified.
+  (Optional, Deprecated)
+  TCPSocket specifies an action involving a TCP port. This field is not supported in liveness probe currently.
   Structure is [documented below](#nested_tcp_socket).