feat(spanner): add support for defaultBackupScheduleType in spanner instance (#12254) (#8644)

[upstream:b551152e1e2375ddd6208b18c1970292b8ff583c]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/12254.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+spanner: added `default_backup_schedule_type` field to  `google_spanner_instance`
+```

google-beta/services/spanner/resource_spanner_instance.go

@@ -229,6 +229,15 @@ This number is on a scale from 0 (no utilization) to 100 (full utilization).`,
 				},
 				ExactlyOneOf: []string{"num_nodes", "processing_units", "autoscaling_config"},
 			},
+			"default_backup_schedule_type": {
+				Type:         schema.TypeString,
+				Computed:     true,
+				Optional:     true,
+				ValidateFunc: verify.ValidateEnum([]string{"NONE", "AUTOMATIC", ""}),
+				Description: `Controls the default backup behavior for new databases within the instance.
+Note that 'AUTOMATIC' is not permitted for free instances, as backups and backup schedules are not allowed for free instances.
+if unset or NONE, no default backup schedule will be created for new databases within the instance. Possible values: ["NONE", "AUTOMATIC"]`,
+			},
 			"labels": {
 				Type:     schema.TypeMap,
 				Optional: true,
@@ -336,6 +345,12 @@ func resourceSpannerInstanceCreate(d *schema.ResourceData, meta interface{}) err
 	} else if v, ok := d.GetOkExists("autoscaling_config"); !tpgresource.IsEmptyValue(reflect.ValueOf(autoscalingConfigProp)) && (ok || !reflect.DeepEqual(v, autoscalingConfigProp)) {
 		obj["autoscalingConfig"] = autoscalingConfigProp
 	}
+	defaultBackupScheduleTypeProp, err := expandSpannerInstanceDefaultBackupScheduleType(d.Get("default_backup_schedule_type"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("default_backup_schedule_type"); !tpgresource.IsEmptyValue(reflect.ValueOf(defaultBackupScheduleTypeProp)) && (ok || !reflect.DeepEqual(v, defaultBackupScheduleTypeProp)) {
+		obj["defaultBackupScheduleType"] = defaultBackupScheduleTypeProp
+	}
 	labelsProp, err := expandSpannerInstanceEffectiveLabels(d.Get("effective_labels"), d, config)
 	if err != nil {
 		return err
@@ -515,6 +530,9 @@ func resourceSpannerInstanceRead(d *schema.ResourceData, meta interface{}) error
 	if err := d.Set("autoscaling_config", flattenSpannerInstanceAutoscalingConfig(res["autoscalingConfig"], d, config)); err != nil {
 		return fmt.Errorf("Error reading Instance: %s", err)
 	}
+	if err := d.Set("default_backup_schedule_type", flattenSpannerInstanceDefaultBackupScheduleType(res["defaultBackupScheduleType"], d, config)); err != nil {
+		return fmt.Errorf("Error reading Instance: %s", err)
+	}
 	if err := d.Set("terraform_labels", flattenSpannerInstanceTerraformLabels(res["labels"], d, config)); err != nil {
 		return fmt.Errorf("Error reading Instance: %s", err)
 	}
@@ -565,6 +583,12 @@ func resourceSpannerInstanceUpdate(d *schema.ResourceData, meta interface{}) err
 	} else if v, ok := d.GetOkExists("autoscaling_config"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, autoscalingConfigProp)) {
 		obj["autoscalingConfig"] = autoscalingConfigProp
 	}
+	defaultBackupScheduleTypeProp, err := expandSpannerInstanceDefaultBackupScheduleType(d.Get("default_backup_schedule_type"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("default_backup_schedule_type"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, defaultBackupScheduleTypeProp)) {
+		obj["defaultBackupScheduleType"] = defaultBackupScheduleTypeProp
+	}
 	labelsProp, err := expandSpannerInstanceEffectiveLabels(d.Get("effective_labels"), d, config)
 	if err != nil {
 		return err
@@ -944,7 +968,9 @@ func flattenSpannerInstanceAutoscalingConfigAutoscalingTargetsStorageUtilization
 
 	return v // let terraform core handle it otherwise
 }
-
+func flattenSpannerInstanceDefaultBackupScheduleType(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	return v
+}
 func flattenSpannerInstanceTerraformLabels(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	if v == nil {
 		return v
@@ -1109,7 +1135,9 @@ func expandSpannerInstanceAutoscalingConfigAutoscalingTargetsHighPriorityCpuUtil
 func expandSpannerInstanceAutoscalingConfigAutoscalingTargetsStorageUtilizationPercent(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
 	return v, nil
 }
-
+func expandSpannerInstanceDefaultBackupScheduleType(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
 func expandSpannerInstanceEffectiveLabels(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (map[string]string, error) {
 	if v == nil {
 		return map[string]string{}, nil
@@ -1149,6 +1177,9 @@ func resourceSpannerInstanceUpdateEncoder(d *schema.ResourceData, meta interface
 	newObj := make(map[string]interface{})
 	newObj["instance"] = obj
 	updateMask := make([]string, 0)
+	if d.HasChange("default_backup_schedule_type") {
+		updateMask = append(updateMask, "defaultBackupScheduleType")
+	}
 	if d.HasChange("num_nodes") {
 		updateMask = append(updateMask, "nodeCount")
 	}

google-beta/services/spanner/resource_spanner_instance_generated_test.go

@@ -62,6 +62,7 @@ resource "google_spanner_instance" "example" {
   config       = "regional-us-central1"
   display_name = "Test Spanner Instance"
   num_nodes    = 2
+  default_backup_schedule_type = "AUTOMATIC"
   labels = {
     "foo" = "bar"
   }

google-beta/services/spanner/resource_spanner_instance_test.go

@@ -321,6 +321,7 @@ resource "google_spanner_instance" "basic" {
   config       = "regional-us-central1"
   display_name = "%s-dname"
   num_nodes    = 1
+  default_backup_schedule_type = "NONE"
 }
 `, name, name)
 }
@@ -412,6 +413,7 @@ resource "google_spanner_instance" "basic" {
       storage_utilization_percent           = %v
     }
   }
+  default_backup_schedule_type = "AUTOMATIC"
 }
 `, name, name, maxProcessingUnits, minProcessingUnits, cupUtilizationPercent, storageUtilizationPercent)
 }

website/docs/r/spanner_instance.html.markdown

@@ -43,6 +43,7 @@ resource "google_spanner_instance" "example" {
   config       = "regional-us-central1"
   display_name = "Test Spanner Instance"
   num_nodes    = 2
+  default_backup_schedule_type = "AUTOMATIC"
   labels = {
     "foo" = "bar"
   }
@@ -171,6 +172,13 @@ The following arguments are supported:
   the instance.
   Structure is [documented below](#nested_autoscaling_config).
 
+* `default_backup_schedule_type` -
+  (Optional)
+  Controls the default backup behavior for new databases within the instance.
+  Note that `AUTOMATIC` is not permitted for free instances, as backups and backup schedules are not allowed for free instances.
+  if unset or NONE, no default backup schedule will be created for new databases within the instance.
+  Possible values are: `NONE`, `AUTOMATIC`.
+
 * `project` - (Optional) The ID of the project in which the resource belongs.
     If it is not provided, the provider project is used.