Made iam updaters accept TerraformResourceData interface (#4426) (#2895)

* Made iam updaters accept TerraformResourceData interface

This allows for easier interoperability with terraform-validator, and is currently the standard for other functions used by terraform-google-conversion

* Corrected make test errors

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/4426.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

google-beta/iam.go

@@ -45,7 +45,7 @@ type (
 	}
 
 	// Factory for generating ResourceIamUpdater for given ResourceData resource
-	newResourceIamUpdaterFunc func(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error)
+	newResourceIamUpdaterFunc func(d TerraformResourceData, config *Config) (ResourceIamUpdater, error)
 
 	// Describes how to modify a policy for a given Terraform IAM (_policy/_member/_binding/_audit_config) resource
 	iamPolicyModifyFunc func(p *cloudresourcemanager.Policy) error

google-beta/iam_api_gateway_api.go

@@ -39,11 +39,11 @@ var ApiGatewayApiIamSchema = map[string]*schema.Schema{
 type ApiGatewayApiIamUpdater struct {
 	project string
 	api     string
-	d       *schema.ResourceData
+	d       TerraformResourceData
 	Config  *Config
 }
 
-func ApiGatewayApiIamUpdaterProducer(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error) {
+func ApiGatewayApiIamUpdaterProducer(d TerraformResourceData, config *Config) (ResourceIamUpdater, error) {
 	values := make(map[string]string)
 
 	project, _ := getProject(d, config)

google-beta/iam_api_gateway_api_config.go

@@ -45,11 +45,11 @@ type ApiGatewayApiConfigIamUpdater struct {
 	project   string
 	api       string
 	apiConfig string
-	d         *schema.ResourceData
+	d         TerraformResourceData
 	Config    *Config
 }
 
-func ApiGatewayApiConfigIamUpdaterProducer(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error) {
+func ApiGatewayApiConfigIamUpdaterProducer(d TerraformResourceData, config *Config) (ResourceIamUpdater, error) {
 	values := make(map[string]string)
 
 	project, _ := getProject(d, config)

google-beta/iam_api_gateway_gateway.go

@@ -46,11 +46,11 @@ type ApiGatewayGatewayIamUpdater struct {
 	project string
 	region  string
 	gateway string
-	d       *schema.ResourceData
+	d       TerraformResourceData
 	Config  *Config
 }
 
-func ApiGatewayGatewayIamUpdaterProducer(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error) {
+func ApiGatewayGatewayIamUpdaterProducer(d TerraformResourceData, config *Config) (ResourceIamUpdater, error) {
 	values := make(map[string]string)
 
 	project, _ := getProject(d, config)

google-beta/iam_artifact_registry_repository.go

@@ -46,11 +46,11 @@ type ArtifactRegistryRepositoryIamUpdater struct {
 	project    string
 	location   string
 	repository string
-	d          *schema.ResourceData
+	d          TerraformResourceData
 	Config     *Config
 }
 
-func ArtifactRegistryRepositoryIamUpdaterProducer(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error) {
+func ArtifactRegistryRepositoryIamUpdaterProducer(d TerraformResourceData, config *Config) (ResourceIamUpdater, error) {
 	values := make(map[string]string)
 
 	project, _ := getProject(d, config)

google-beta/iam_big_query_table.go

@@ -45,11 +45,11 @@ type BigQueryTableIamUpdater struct {
 	project   string
 	datasetId string
 	tableId   string
-	d         *schema.ResourceData
+	d         TerraformResourceData
 	Config    *Config
 }
 
-func BigQueryTableIamUpdaterProducer(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error) {
+func BigQueryTableIamUpdaterProducer(d TerraformResourceData, config *Config) (ResourceIamUpdater, error) {
 	values := make(map[string]string)
 
 	project, _ := getProject(d, config)

google-beta/iam_bigquery_dataset.go

@@ -33,11 +33,11 @@ var bigqueryAccessPrimitiveToRoleMap = map[string]string{
 type BigqueryDatasetIamUpdater struct {
 	project   string
 	datasetId string
-	d         *schema.ResourceData
+	d         TerraformResourceData
 	Config    *Config
 }
 
-func NewBigqueryDatasetIamUpdater(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error) {
+func NewBigqueryDatasetIamUpdater(d TerraformResourceData, config *Config) (ResourceIamUpdater, error) {
 	project, err := getProject(d, config)
 	if err != nil {
 		return nil, err

google-beta/iam_bigtable_instance.go

@@ -26,11 +26,11 @@ var IamBigtableInstanceSchema = map[string]*schema.Schema{
 type BigtableInstanceIamUpdater struct {
 	project  string
 	instance string
-	d        *schema.ResourceData
+	d        TerraformResourceData
 	Config   *Config
 }
 
-func NewBigtableInstanceUpdater(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error) {
+func NewBigtableInstanceUpdater(d TerraformResourceData, config *Config) (ResourceIamUpdater, error) {
 	project, err := getProject(d, config)
 	if err != nil {
 		return nil, err

google-beta/iam_bigtable_table.go

@@ -33,11 +33,11 @@ type BigtableTableIamUpdater struct {
 	project  string
 	instance string
 	table    string
-	d        *schema.ResourceData
+	d        TerraformResourceData
 	Config   *Config
 }
 
-func NewBigtableTableUpdater(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error) {
+func NewBigtableTableUpdater(d TerraformResourceData, config *Config) (ResourceIamUpdater, error) {
 	project, err := getProject(d, config)
 	if err != nil {
 		return nil, err