Cherrypick storage_bucket lifecycle_rule fix

Author: c2thorn

.changelog/4192.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+storage: fixed an issue in `google_storage_bucket` where `lifecycle_rules` were always included in update requests
+```

google-beta/resource_storage_bucket.go

@@ -476,7 +476,7 @@ func resourceStorageBucketUpdate(d *schema.ResourceData, meta interface{}) error
 
 	sb := &storage.Bucket{}
 
-	if d.HasChange("lifecycle_rule") {
+	if detectLifecycleChange(d) {
 		lifecycle, err := expandStorageBucketLifecycle(d.Get("lifecycle_rule"))
 		if err != nil {
 			return err
@@ -1307,3 +1307,22 @@ func lockRetentionPolicy(bucketsService *storage.BucketsService, bucketName stri
 
 	return nil
 }
+
+// d.HasChange("lifecycle_rule") always returns true, giving false positives. This function detects changes
+// to the list size or the actions/conditions of rules directly.
+func detectLifecycleChange(d *schema.ResourceData) bool {
+	if d.HasChange("lifecycle_rule.#") {
+		return true
+	}
+
+	if l, ok := d.GetOk("lifecycle_rule"); ok {
+		lifecycleRules := l.([]interface{})
+		for i := range lifecycleRules {
+			if d.HasChange(fmt.Sprintf("lifecycle_rule.%d.action", i)) || d.HasChange(fmt.Sprintf("lifecycle_rule.%d.condition", i)) {
+				return true
+			}
+		}
+	}
+
+	return false
+}