Empty reservations must ignore empty (#3541) (#2089)

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/3541.txt

@@ -0,0 +1,2 @@
+```release-note:none
+```

google-beta/resource_bigquery_reservation_reservation_generated_test.go

@@ -51,7 +51,7 @@ resource "google_bigquery_reservation" "reservation" {
 	// Set to 0 for testing purposes
 	// In reality this would be larger than zero
 	slot_capacity  = 0
-	ignore_idle_slots = true
+	ignore_idle_slots = false
 }
 `, context)
 }

google-beta/resource_bigquery_reservation_test.go

@@ -6,7 +6,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
 )
 
-func TestAccBigqueryReservationReservation_bigqueryReservationUpdate(t *testing.T) {
+func TestAccBigqueryReservationReservation_bigqueryReservation(t *testing.T) {
 	t.Parallel()
 
 	location := "asia-northeast1"
@@ -28,33 +28,12 @@ func TestAccBigqueryReservationReservation_bigqueryReservationUpdate(t *testing.
 				ImportState:       true,
 				ImportStateVerify: true,
 			},
-			{
-				Config: testAccBigqueryReservationReservation_bigqueryReservationUpdate(context),
-			},
-			{
-				ResourceName:      "google_bigquery_reservation.reservation",
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
 		},
 	})
 }
 
 func testAccBigqueryReservationReservation_bigqueryReservationBasic(context map[string]interface{}) string {
 	return Nprintf(`
-resource "google_bigquery_reservation" "reservation" {
-	name           = "reservation%{random_suffix}"
-	location       = "%{location}"
-	// Set to 0 for testing purposes
-	// In reality this would be larger than zero
-	slot_capacity  = 0
-	ignore_idle_slots = true
-}
-`, context)
-}
-
-func testAccBigqueryReservationReservation_bigqueryReservationUpdate(context map[string]interface{}) string {
-	return Nprintf(`
 resource "google_bigquery_reservation" "reservation" {
 	name           = "reservation%{random_suffix}"
 	location       = "%{location}"

website/docs/r/bigquery_reservation.html.markdown

@@ -49,7 +49,7 @@ resource "google_bigquery_reservation" "reservation" {
 	// Set to 0 for testing purposes
 	// In reality this would be larger than zero
 	slot_capacity  = 0
-	ignore_idle_slots = true
+	ignore_idle_slots = false
 }
 ```