fixed - checking the length of the right variable (#4227) (#2723)

modular-magician · web-flow · commit bc0b75f9c103 · 2020-11-16T11:30:07.000-08:00
* fixed-checking the length of the right variable

* lenght check added begining of the function as per PR comments

Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/4227.txt b/.changelog/4227.txt
@@ -0,0 +1,2 @@
+```release-note:none
+```
diff --git a/google-beta/resource_storage_bucket.go b/google-beta/resource_storage_bucket.go
@@ -843,10 +843,10 @@ func resourceStorageBucketStateImporter(d *schema.ResourceData, meta interface{}
 }
 
 func expandCors(configured []interface{}) []*storage.BucketCors {
-	corsRules := make([]*storage.BucketCors, 0, len(configured))
-	if len(corsRules) == 0 {
+	if len(configured) == 0 {
 		return nil
 	}
+	corsRules := make([]*storage.BucketCors, 0, len(configured))
 	for _, raw := range configured {
 		data := raw.(map[string]interface{})
 		corsRule := storage.BucketCors{

Original file line number	Diff line number	Diff line change
`@@ -843,10 +843,10 @@ func resourceStorageBucketStateImporter(d *schema.ResourceData, meta interface{}`
`843`	`843`	`}`
`844`	`844`
`845`	`845`	`func expandCors(configured []interface{}) []*storage.BucketCors {`
`846`		`- corsRules := make([]*storage.BucketCors, 0, len(configured))`
`847`		`- if len(corsRules) == 0 {`
	`846`	`+ if len(configured) == 0 {`
`848`	`847`	`return nil`
`849`	`848`	`}`
	`849`	`+ corsRules := make([]*storage.BucketCors, 0, len(configured))`
`850`	`850`	`for _, raw := range configured {`
`851`	`851`	`data := raw.(map[string]interface{})`
`852`	`852`	`corsRule := storage.BucketCors{`