add TestAccProviderMeta_setModuleName test back to VCR tests (#4588) (#3056)

modular-magician · web-flow · commit be15fb574f9f · 2021-03-15T07:51:35.000-07:00
Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/4588.txt b/.changelog/4588.txt
@@ -0,0 +1,3 @@
+```release-note:none
+
+```
diff --git a/google-beta/provider_test.go b/google-beta/provider_test.go
@@ -494,8 +494,6 @@ func TestAccProviderBasePath_setInvalidBasePath(t *testing.T) {
 }
 
 func TestAccProviderMeta_setModuleName(t *testing.T) {
-	// not expected to succeed yet. see https://github.com/hashicorp/terraform-provider-google/issues/7370
-	skipIfVcr(t)
 	t.Parallel()
 
 	moduleName := "my-module"
diff --git a/google-beta/resource_dataflow_flex_template_job_test.go b/google-beta/resource_dataflow_flex_template_job_test.go
@@ -8,7 +8,7 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
-	"google.golang.org/api/compute/v1"
+	compute "google.golang.org/api/compute/v1"
 )
 
 func TestAccDataflowFlexTemplateJob_basic(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -494,8 +494,6 @@ func TestAccProviderBasePath_setInvalidBasePath(t *testing.T) {`
`494`	`494`	`}`
`495`	`495`
`496`	`496`	`func TestAccProviderMeta_setModuleName(t *testing.T) {`
`497`		`- // not expected to succeed yet. see https://github.com/hashicorp/terraform-provider-google/issues/7370`
`498`		`- skipIfVcr(t)`
`499`	`497`	`t.Parallel()`
`500`	`498`
`501`	`499`	`moduleName := "my-module"`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ import (`
`8`	`8`
`9`	`9`	`"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"`
`10`	`10`	`"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"`
`11`		`- "google.golang.org/api/compute/v1"`
	`11`	`+ compute "google.golang.org/api/compute/v1"`
`12`	`12`	`)`
`13`	`13`
`14`	`14`	`func TestAccDataflowFlexTemplateJob_basic(t *testing.T) {`