Replace = with == (#8364) (#5951)

* Fix .erb warning about `=` used in conditional

* Update test to point where it fails due to an API error, instead of test definition error

* Fix disk name to start with `tf-test-`

* Fix missing variable

* Use key name

* Skip test, remove duplicate declaration

---------

Signed-off-by: Modular Magician <[email protected]>
Co-authored-by: Sarah French <[email protected]>
Co-authored-by: Sarah French <[email protected]>

Author: modular-magician

.changelog/8364.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

google-beta/resource_compute_disk_test.go

@@ -550,6 +550,42 @@ func TestAccComputeDisk_encryptionKMS(t *testing.T) {
 	})
 }
 
+func TestAccComputeDisk_pdHyperDiskEnableConfidentialCompute(t *testing.T) {
+	t.Skip()
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix":        acctest.RandString(t, 10),
+		"kms":                  acctest.BootstrapKMSKey(t).CryptoKey.Name, // global KMS key
+		"disk_size":            64,
+		"confidential_compute": true,
+	}
+
+	var disk compute.Disk
+
+	VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeDiskDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeDisk_pdHyperDiskEnableConfidentialCompute(context),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckComputeDiskExists(
+						t, "google_compute_disk.foobar", envvar.GetTestProjectFromEnv(), &disk),
+					testAccCheckEncryptionKey(
+						t, "google_compute_disk.foobar", &disk),
+				),
+			},
+			{
+				ResourceName:      "google_compute_disk.foobar",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 func TestAccComputeDisk_deleteDetach(t *testing.T) {
 	t.Parallel()
 
@@ -662,6 +698,49 @@ func TestAccComputeDisk_pdExtremeImplicitProvisionedIops(t *testing.T) {
 	})
 }
 
+func TestAccComputeDisk_resourcePolicies(t *testing.T) {
+	t.Parallel()
+
+	diskName := fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))
+	policyName := fmt.Sprintf("tf-test-policy-%s", acctest.RandString(t, 10))
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeDisk_resourcePolicies(diskName, policyName),
+			},
+			{
+				ResourceName:      "google_compute_disk.foobar",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
+func TestAccComputeDisk_multiWriter(t *testing.T) {
+	t.Parallel()
+	instanceName := fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))
+	diskName := fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeDisk_multiWriter(instanceName, diskName, true),
+			},
+			{
+				ResourceName:      "google_compute_disk.foobar",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 func testAccCheckComputeDiskExists(t *testing.T, n, p string, disk *compute.Disk) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		rs, ok := s.RootModule().Resources[n]
@@ -1029,6 +1108,80 @@ resource "google_compute_disk" "foobar" {
 `, diskName)
 }
 
+func testAccComputeDisk_resourcePolicies(diskName, policyName string) string {
+	return fmt.Sprintf(`
+data "google_compute_image" "my_image" {
+  family  = "debian-11"
+  project = "debian-cloud"
+}
+
+resource "google_compute_resource_policy" "foo" {
+  name     = "%s"
+  region   = "us-central1"
+  snapshot_schedule_policy {
+    schedule {
+      daily_schedule {
+        days_in_cycle = 1
+        start_time    = "04:00"
+      }
+    }
+  }
+}
+
+resource "google_compute_disk" "foobar" {
+  name     = "%s"
+  image    = data.google_compute_image.my_image.self_link
+  size     = 50
+  type     = "pd-ssd"
+  zone     = "us-central1-a"
+  resource_policies = [google_compute_resource_policy.foo.self_link]
+}
+`, policyName, diskName)
+}
+
+func testAccComputeDisk_multiWriter(instance string, diskName string, enableMultiwriter bool) string {
+	return fmt.Sprintf(`
+data "google_compute_image" "my_image" {
+  family  = "debian-11"
+  project = "debian-cloud"
+}
+
+resource "google_compute_disk" "foobar" {
+  name         = "%s"
+  size         = 10
+  type         = "pd-ssd"
+	zone         = "us-central1-a"
+	multi_writer  = %t
+}
+
+resource "google_compute_instance" "foobar" {
+  name           = "%s"
+  machine_type   = "n2-standard-2"
+  zone           = "us-central1-a"
+  can_ip_forward = false
+	tags           = ["foo", "bar"]
+
+  boot_disk {
+    initialize_params {
+      image = data.google_compute_image.my_image.self_link
+    }
+	}
+
+	attached_disk {
+    source = google_compute_disk.foobar.name
+  }
+
+  network_interface {
+    network = "default"
+  }
+
+  metadata = {
+    foo = "bar"
+  }
+}
+`, diskName, enableMultiwriter, instance)
+}
+
 func testAccComputeDisk_diskClone(diskName, refSelector string) string {
 	return fmt.Sprintf(`
 	data "google_compute_image" "my_image" {