Skip to content

Commit c77fdcf

Browse files
Fixed statement about HA (#5948) (#4229)
* Fixed statement about HA * Added postgres nuance * Update markdown Signed-off-by: Modular Magician <[email protected]>
1 parent c9a99b7 commit c77fdcf

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

.changelog/5948.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
```release-note:none
2+
```

google-beta/resource_sql_database_instance.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,12 @@ func resourceSqlDatabaseInstance() *schema.Resource {
160160
Default: "ZONAL",
161161
ValidateFunc: validation.StringInSlice([]string{"REGIONAL", "ZONAL"}, false),
162162
Description: `The availability type of the Cloud SQL instance, high availability
163-
(REGIONAL) or single zone (ZONAL). For MySQL instances, ensure that
163+
(REGIONAL) or single zone (ZONAL). For MySQL and SQL Server instances, ensure that
164164
settings.backup_configuration.enabled and
165-
settings.backup_configuration.binary_log_enabled are both set to true.`,
165+
settings.backup_configuration.binary_log_enabled are both set to true.
166+
For Postgres instances, ensure that settings.backup_configuration.enabled
167+
and settings.backup_configuration.point_in_time_recovery_enabled
168+
are both set to true.`,
166169
},
167170
"backup_configuration": {
168171
Type: schema.TypeList,

website/docs/r/sql_database_instance.html.markdown

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,10 @@ The `settings` block supports:
230230
active. Can be either `ALWAYS`, `NEVER` or `ON_DEMAND`.
231231

232232
* `availability_type` - (Optional, Default: `ZONAL`) The availability type of the Cloud SQL
233-
instance, high availability (`REGIONAL`) or single zone (`ZONAL`).' For MySQL
234-
instances, ensure that `settings.backup_configuration.enabled` and
235-
`settings.backup_configuration.binary_log_enabled` are both set to `true`.
233+
instance, high availability (`REGIONAL`) or single zone (`ZONAL`).' For MySQL and SQL Server instances,
234+
ensure that `settings.backup_configuration.enabled` and `settings.backup_configuration.binary_log_enabled`
235+
are both set to `true`. For Postgres instances, ensure that `settings.backup_configuration.enabled`
236+
and `settings.backup_configuration.point_in_time_recovery_enabled` are both set to `true`.
236237

237238
* `collation` - (Optional) The name of server instance collation.
238239

0 commit comments

Comments
 (0)