Added tag value resource (#4603) (#3097)

* Added tag value resource

* Copied tag key tests and adjusted for values

* Corrected duplicate map keys

* Added validation to shortnames and descriptions

* Renamed tags tests since they're no longer tag-key-only

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/4603.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+`google_tags_tag_value`
+```

google-beta/provider.go

@@ -844,9 +844,9 @@ func Provider() *schema.Provider {
 	return provider
 }
 
-// Generated resources: 217
+// Generated resources: 218
 // Generated IAM resources: 111
-// Total generated resources: 328
+// Total generated resources: 329
 func ResourceMap() map[string]*schema.Resource {
 	resourceMap, _ := ResourceMapWithErrors()
 	return resourceMap
@@ -1180,6 +1180,7 @@ func ResourceMapWithErrors() (map[string]*schema.Resource, error) {
 			"google_storage_default_object_access_control":                 resourceStorageDefaultObjectAccessControl(),
 			"google_storage_hmac_key":                                      resourceStorageHmacKey(),
 			"google_tags_tag_key":                                          resourceTagsTagKey(),
+			"google_tags_tag_value":                                        resourceTagsTagValue(),
 			"google_tpu_node":                                              resourceTPUNode(),
 			"google_vpc_access_connector":                                  resourceVPCAccessConnector(),
 			"google_workflows_workflow":                                    resourceWorkflowsWorkflow(),

google-beta/resource_tags_tag_key.go

@@ -22,6 +22,7 @@ import (
 	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 func resourceTagsTagKey() *schema.Resource {
@@ -49,17 +50,19 @@ func resourceTagsTagKey() *schema.Resource {
 				Description: `Input only. The resource name of the new TagKey's parent. Must be of the form organizations/{org_id}.`,
 			},
 			"short_name": {
-				Type:     schema.TypeString,
-				Required: true,
-				ForceNew: true,
+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validation.StringLenBetween(1, 63),
 				Description: `Input only. The user friendly name for a TagKey. The short name should be unique for TagKeys within the same tag namespace.
 
 The short name must be 1-63 characters, beginning and ending with an alphanumeric character ([a-z0-9A-Z]) with dashes (-), underscores (_), dots (.), and alphanumerics between.`,
 			},
 			"description": {
-				Type:        schema.TypeString,
-				Optional:    true,
-				Description: `User-assigned description of the TagKey. Must not exceed 256 characters.`,
+				Type:         schema.TypeString,
+				Optional:     true,
+				ValidateFunc: validation.StringLenBetween(0, 256),
+				Description:  `User-assigned description of the TagKey. Must not exceed 256 characters.`,
 			},
 			"create_time": {
 				Type:     schema.TypeString,