Add network_attachment on gce instance data source (#9856) (#6891)

* addition of network attachament field on GCE instance data source

* remove of unnecessary part of code that add network_attachemtn
[upstream:c011b040df99388289bb7819db455e5559678acf]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/9856.txt

@@ -0,0 +1,3 @@
+```release-note:none
+ docs: added `network_attachment` to `google_compute_instance` data source (beta)
+```

google-beta/services/compute/data_source_google_compute_instance_test.go

@@ -108,8 +108,7 @@ resource "google_compute_instance" "foo" {
   }
 
   network_interface {
-    network = "default"
-
+    network = "default"	
     access_config {
       // Ephemeral IP
     }
@@ -139,3 +138,96 @@ data "google_compute_instance" "baz" {
 }
 `, instanceName)
 }
+func TestAccDataSourceComputeInstance_networkAttachmentUsageExample(t *testing.T) {
+	t.Parallel()
+
+	instanceName := fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
+		CheckDestroy:             testAccCheckComputeInstanceDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccDataSourceComputeInstance_networkAttachmentUsageConfig(instanceName),
+				Check:  resource.TestCheckResourceAttrSet("data.google_compute_instance.bar", "network_interface.1.network_attachment"),
+			},
+		},
+	})
+}
+
+func testAccDataSourceComputeInstance_networkAttachmentUsageConfig(instanceName string) string {
+	return fmt.Sprintf(`
+resource "google_compute_instance" "foo" {
+	provider = google-beta
+  name           = "%s"
+  machine_type   = "n1-standard-1"   // can't be e2 because of local-ssd
+  zone           = "us-central1-a"
+  can_ip_forward = false
+  tags           = ["foo", "bar"]
+
+  boot_disk {
+    initialize_params {
+      image = "debian-8-jessie-v20160803"
+    }
+  }
+
+  scratch_disk {
+	interface = "SCSI"
+  }
+
+  network_interface {
+    network = "default"
+	
+    access_config {
+      // Ephemeral IP
+    }
+  }
+
+  network_interface { 
+	network_attachment = google_compute_network_attachment.net_attar_default.self_link   
+  }
+
+ 
+
+  labels = {
+    my_key       = "my_value"
+    my_other_key = "my_other_value"
+  }
+
+  enable_display = true
+}
+
+data "google_compute_instance" "bar" {
+	provider = google-beta
+  name = google_compute_instance.foo.name
+  zone = "us-central1-a"
+}
+
+data "google_compute_instance" "baz" {
+	provider = google-beta
+  self_link = google_compute_instance.foo.self_link
+}
+resource "google_compute_network" "net_att_default" {   
+	provider = google-beta
+    name = "basic-network-att"
+    auto_create_subnetworks = false
+}
+
+resource "google_compute_subnetwork" "subnet_att_default" {    
+	provider = google-beta
+    name   = "basic-subnetwork-att" 
+	region = "us-central1"  
+    network       = google_compute_network.net_att_default.id
+    ip_cidr_range = "10.0.0.0/16"
+}
+
+resource "google_compute_network_attachment" "net_attar_default" {   
+	provider = google-beta 
+    name   = "basic-attachment"
+    region = "us-central1"
+    subnetworks = [google_compute_subnetwork.subnet_att_default.id]
+    connection_preference = "ACCEPT_AUTOMATIC"
+}
+`, instanceName)
+}

website/docs/d/compute_instance.html.markdown

@@ -159,6 +159,8 @@ The following arguments are supported:
 
 * `alias_ip_range` - An array of alias IP ranges for this network interface. Structure [documented below](#nested_alias_ip_range).
 
+* `network_attachment` - [Beta](https://terraform.io/docs/providers/google/guides/provider_versions.html) The URL of the network attachment to this interface.	
+
 <a name="nested_access_config"></a>The `access_config` block supports:
 
 * `nat_ip` - The IP address that is be 1:1 mapped to the instance's