Skip to content

Commit d015a05

Browse files
Check for diffs in allowed ranges set (#3529) (#2083)
* Check for diffs in allowed ranges set, checking in parent object produces incorrect changes due to sets internal representation * Add comment Signed-off-by: Modular Magician <[email protected]>
1 parent 257077d commit d015a05

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.changelog/3529.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:none
2+
3+
```

google-beta/resource_composer_environment.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,9 @@ func resourceComposerEnvironmentUpdate(d *schema.ResourceData, meta interface{})
571571
d.SetPartial("config")
572572
}
573573

574-
if d.HasChange("config.0.web_server_network_access_control") {
574+
// If web_server_network_access_control has more fields added it may require changes here.
575+
// This is scoped specifically to allowed_ip_range due to https://github.com/hashicorp/terraform-plugin-sdk/issues/98
576+
if d.HasChange("config.0.web_server_network_access_control.0.allowed_ip_range") {
575577
patchObj := &composer.Environment{Config: &composer.EnvironmentConfig{}}
576578
if config != nil {
577579
patchObj.Config.WebServerNetworkAccessControl = config.WebServerNetworkAccessControl

0 commit comments

Comments
 (0)