Skip to content

Commit d1d6fc4

Browse files
Fix google_notebooks_instance labels not being able to be updated (#9933) (#7028)
* add labels to runtime update test * Add labels to ImportStateVerifyIgnore * fix indentation [upstream:47d6f3bb8e09b0a6265cee24852e973bcb326513] Signed-off-by: Modular Magician <[email protected]>
1 parent b36863a commit d1d6fc4

File tree

2 files changed

+18
-9
lines changed

2 files changed

+18
-9
lines changed

.changelog/9933.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
3+
```

google-beta/services/notebooks/resource_notebooks_runtime_test.go

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,25 +23,28 @@ func TestAccNotebooksRuntime_update(t *testing.T) {
2323
Config: testAccNotebooksRuntime_basic(context),
2424
},
2525
{
26-
ResourceName: "google_notebooks_runtime.runtime",
27-
ImportState: true,
28-
ImportStateVerify: true,
26+
ResourceName: "google_notebooks_runtime.runtime",
27+
ImportState: true,
28+
ImportStateVerify: true,
29+
ImportStateVerifyIgnore: []string{"labels", "terraform_labels"},
2930
},
3031
{
3132
Config: testAccNotebooksRuntime_update(context),
3233
},
3334
{
34-
ResourceName: "google_notebooks_runtime.runtime",
35-
ImportState: true,
36-
ImportStateVerify: true,
35+
ResourceName: "google_notebooks_runtime.runtime",
36+
ImportState: true,
37+
ImportStateVerify: true,
38+
ImportStateVerifyIgnore: []string{"labels", "terraform_labels"},
3739
},
3840
{
3941
Config: testAccNotebooksRuntime_basic(context),
4042
},
4143
{
42-
ResourceName: "google_notebooks_runtime.runtime",
43-
ImportState: true,
44-
ImportStateVerify: true,
44+
ResourceName: "google_notebooks_runtime.runtime",
45+
ImportState: true,
46+
ImportStateVerify: true,
47+
ImportStateVerifyIgnore: []string{"labels", "terraform_labels"},
4548
},
4649
},
4750
})
@@ -101,6 +104,9 @@ resource "google_notebooks_runtime" "runtime" {
101104
reserved_ip_range = "192.168.255.0/24"
102105
}
103106
}
107+
labels = {
108+
k = "val"
109+
}
104110
}
105111
`, context)
106112
}

0 commit comments

Comments
 (0)