Add nil check to exprOptions.RecaptchaOptions in google_compute_security_policy (#15125) (#10715)

[upstream:1a52c1d06bcef50a5e2f578aa14d2432dbe9d163]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/15125.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+compute: fixed a crash in `google_compute_security_policy` due to a changed API response for empty `match.0.expr_options` blocks
+```

google-beta/services/compute/resource_compute_security_policy.go

@@ -1374,15 +1374,24 @@ func flattenMatchExprOptions(exprOptions *compute.SecurityPolicyRuleMatcherExprO
 		return nil
 	}
 
-	// We check if the API is returning a empty non-null value then we find the current value for this field in the rule config and check if its empty
+	// The API can return an explicit entry `exprOptions` object, causing evaluation of the `recaptcha_options` settings to fail as it's nil: https://github.com/hashicorp/terraform-provider-google/issues/24334
+	// Explicitly check it's available and exit early if not.
+	if exprOptions.RecaptchaOptions == nil {
+		return nil
+	}
+
+	// The API can return an explicit empty rule causing an issue: https://github.com/hashicorp/terraform-provider-google/issues/16882#issuecomment-2474528447
+	// We check if the API is returning a empty non-null value then we find the current value for this field in the rule config and check if its empty.
 	if (tpgresource.IsEmptyValue(reflect.ValueOf(exprOptions.RecaptchaOptions.ActionTokenSiteKeys)) &&
 		tpgresource.IsEmptyValue(reflect.ValueOf(exprOptions.RecaptchaOptions.SessionTokenSiteKeys))) &&
 		verifyRulePriorityCompareEmptyValues(d, rulePriority, "recaptcha_options") {
 		return nil
 	}
 
 	data := map[string]interface{}{
+		// NOTE: when adding new entries, the recaptcha_options rule above will need to be revised
 		"recaptcha_options": flattenMatchExprOptionsRecaptchaOptions(exprOptions.RecaptchaOptions),
+		// NOTE: when adding new entries, the recaptcha_options rule above will need to be revised
 	}
 
 	return []map[string]interface{}{data}