Add force_destroy to spanner instance (#4644) (#3227)

Co-authored-by: upodroid <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: upodroid <[email protected]>

Author: modular-magician

.changelog/4644.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+spanner: added `force_destroy` to `google_spanner_instance` to delete instances that have backups enabled.
+```

google-beta/resource_dataflow_flex_template_job_test.go

@@ -8,7 +8,7 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
-	compute "google.golang.org/api/compute/v1"
+	"google.golang.org/api/compute/v1"
 )
 
 func TestAccDataflowFlexTemplateJob_basic(t *testing.T) {

google-beta/resource_spanner_instance.go

@@ -27,6 +27,41 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
+func deleteSpannerBackups(d *schema.ResourceData, config *Config, res map[string]interface{}, userAgent string, billingProject string) error {
+	var v interface{}
+	var ok bool
+
+	v, ok = res["backups"]
+	if !ok || v == nil {
+		return nil
+	}
+
+	// Iterate over the list and delete each backup.
+	for _, itemRaw := range v.([]interface{}) {
+		if itemRaw == nil {
+			continue
+		}
+		item := itemRaw.(map[string]interface{})
+
+		backupName := item["name"].(string)
+
+		log.Printf("[DEBUG] Found backups for resource %q: %#v)", d.Id(), item)
+
+		path := "{{SpannerBasePath}}" + backupName
+
+		url, err := replaceVars(d, config, path)
+		if err != nil {
+			return err
+		}
+
+		_, err = sendRequest(config, "DELETE", billingProject, url, userAgent, nil)
+		if err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
 func resourceSpannerInstance() *schema.Resource {
 	return &schema.Resource{
 		Create: resourceSpannerInstanceCreate,
@@ -94,6 +129,11 @@ Example: { "name": "wrench", "mass": "1.3kg", "count": "3" }.`,
 				Computed:    true,
 				Description: `Instance status: 'CREATING' or 'READY'.`,
 			},
+			"force_destroy": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Default:  false,
+			},
 			"project": {
 				Type:     schema.TypeString,
 				Optional: true,
@@ -263,6 +303,12 @@ func resourceSpannerInstanceRead(d *schema.ResourceData, meta interface{}) error
 		return nil
 	}
 
+	// Explicitly set virtual fields to default values if unset
+	if _, ok := d.GetOkExists("force_destroy"); !ok {
+		if err := d.Set("force_destroy", false); err != nil {
+			return fmt.Errorf("Error setting force_destroy: %s", err)
+		}
+	}
 	if err := d.Set("project", project); err != nil {
 		return fmt.Errorf("Error reading Instance: %s", err)
 	}
@@ -381,6 +427,24 @@ func resourceSpannerInstanceDelete(d *schema.ResourceData, meta interface{}) err
 	}
 
 	var obj map[string]interface{}
+
+	if d.Get("force_destroy").(bool) {
+		backupsUrl, err := replaceVars(d, config, "{{SpannerBasePath}}projects/{{project}}/instances/{{name}}/backups")
+		if err != nil {
+			return err
+		}
+
+		resp, err := sendRequest(config, "GET", billingProject, backupsUrl, userAgent, nil)
+		if err != nil {
+			// API returns 200 if no backups exist but the instance still exists, hence the error check.
+			return handleNotFoundError(err, d, fmt.Sprintf("SpannerInstance %q", d.Id()))
+		}
+
+		err = deleteSpannerBackups(d, config, resp, billingProject, userAgent)
+		if err != nil {
+			return err
+		}
+	}
 	log.Printf("[DEBUG] Deleting Instance %q", d.Id())
 
 	// err == nil indicates that the billing_project value was found
@@ -414,6 +478,11 @@ func resourceSpannerInstanceImport(d *schema.ResourceData, meta interface{}) ([]
 	}
 	d.SetId(id)
 
+	// Explicitly set virtual fields to default values on import
+	if err := d.Set("force_destroy", false); err != nil {
+		return nil, fmt.Errorf("Error setting force_destroy: %s", err)
+	}
+
 	return []*schema.ResourceData{d}, nil
 }
 

google-beta/resource_spanner_instance_sweeper_test.go

@@ -113,6 +113,9 @@ The following arguments are supported:
 * `project` - (Optional) The ID of the project in which the resource belongs.
     If it is not provided, the provider project is used.
 
+* `force_destroy` - (Optional) When deleting a spanner instance, this boolean option will delete all backups of this instance.
+This must be set to true if you created a backup manually in the console.
+
 
 ## Attributes Reference