check if instance manager not found on delete, don't return an error (#7903) (#5614)

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/7903.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+compute: fixed crash on `terraform destroy -refresh=false` for instance group managers with `wait_for_instances = "true"` if the instance group manager was not found
+```

google-beta/resource_compute_instance_group_manager.go

@@ -3,6 +3,7 @@ package google
 import (
 	"fmt"
 	"log"
+	"regexp"
 	"strings"
 	"time"
 
@@ -953,6 +954,14 @@ func resourceComputeInstanceGroupManagerDelete(d *schema.ResourceData, meta inte
 	if d.Get("wait_for_instances").(bool) {
 		err := computeIGMWaitForInstanceStatus(d, meta)
 		if err != nil {
+			notFound, reErr := regexp.MatchString(`not found`, err.Error())
+			if reErr != nil {
+				return reErr
+			}
+			if notFound {
+				// manager was not found, we can exit gracefully
+				return nil
+			}
 			return err
 		}
 	}

google-beta/resource_compute_region_instance_group_manager.go

@@ -3,6 +3,7 @@ package google
 import (
 	"fmt"
 	"log"
+	"regexp"
 	"strings"
 	"time"
 
@@ -622,6 +623,12 @@ func waitForInstancesRefreshFunc(f getInstanceManagerFunc, waitForUpdates bool,
 			log.Printf("[WARNING] Error in fetching manager while waiting for instances to come up: %s\n", err)
 			return nil, "error", err
 		}
+		if m == nil {
+			// getManager/getRegional manager call handleNotFoundError, which will return a nil error and nil object in the case
+			// that the original error was a 404. if m == nil here, we will assume that it was not found return an "instance manager not found"
+			// error so that we can parse it later on and handle it there
+			return nil, "error", fmt.Errorf("instance manager not found")
+		}
 		if m.Status.IsStable {
 			if waitForUpdates {
 				// waitForUpdates waits for versions to be reached and per instance configs to be updated (if present)
@@ -886,6 +893,14 @@ func resourceComputeRegionInstanceGroupManagerDelete(d *schema.ResourceData, met
 	if d.Get("wait_for_instances").(bool) {
 		err := computeRIGMWaitForInstanceStatus(d, meta)
 		if err != nil {
+			notFound, reErr := regexp.MatchString(`not found`, err.Error())
+			if reErr != nil {
+				return reErr
+			}
+			if notFound {
+				// manager was not found, we can exit gracefully
+				return nil
+			}
 			return err
 		}
 	}