Skip to content

Commit eea40cc

Browse files
Fixed sweeping of incidentally-created queues (#12529) (#8885)
[upstream:5c620d651d045d3053c8f4cf86a315ff5318f3bd] Signed-off-by: Modular Magician <[email protected]>
1 parent 339d16d commit eea40cc

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

.changelog/12529.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:none
2+
3+
```

google-beta/sweeper/gcp_sweeper.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,15 @@ var testResourcePrefixes = []string{
2323
// include a "-" or "_" respectively, and they are the preferred prefix for our test resources to use
2424
"tf-test",
2525
"tf_test",
26+
// Resource-specific prefixes that should be moved to the corresponding resource sweeper as part of https://github.com/hashicorp/terraform-provider-google/issues/20638
2627
"tfgen",
2728
"gke-us-central1-tf", // composer-created disks which are abandoned by design (https://cloud.google.com/composer/pricing)
2829
"gcs-bucket-tf-test-", // https://github.com/hashicorp/terraform-provider-google/issues/8909
2930
"df-", // https://github.com/hashicorp/terraform-provider-google/issues/8909
3031
"resourcegroup-", // https://github.com/hashicorp/terraform-provider-google/issues/8924
3132
"cluster-", // https://github.com/hashicorp/terraform-provider-google/issues/8924
3233
"k8s-fw-", // firewall rules are getting created and not cleaned up by k8 resources using this prefix
34+
"ext-tf-test", // Cloud Tasks Queues created automatically by tests for `google_firebase_extensions_instance`.
3335
}
3436

3537
// SharedConfigForRegion returns a common config setup needed for the sweeper

0 commit comments

Comments
 (0)