Add a new 'data_classification' field on 'dataplex_aspect_type' resource. (#15317) (#10929)

[upstream:c61d59ea591d95f20d6de8e2ae25ba033faaa2a4]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/15317.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+compute: added `data_classification` field to `google_dataplex_aspect_type` resource
+```

google-beta/services/dataplex/iam_dataplex_aspect_type_generated_test.go

@@ -104,6 +104,7 @@ resource "google_dataplex_aspect_type" "test_aspect_type_basic" {
   project = "%{project_name}"
   location = "us-central1"
 
+  data_classification = "DATA_CLASSIFICATION_UNSPECIFIED"
   metadata_template = <<EOF
 {
   "name": "tf-test-template",
@@ -149,6 +150,7 @@ resource "google_dataplex_aspect_type" "test_aspect_type_basic" {
   project = "%{project_name}"
   location = "us-central1"
 
+  data_classification = "DATA_CLASSIFICATION_UNSPECIFIED"
   metadata_template = <<EOF
 {
   "name": "tf-test-template",
@@ -209,6 +211,7 @@ resource "google_dataplex_aspect_type" "test_aspect_type_basic" {
   project = "%{project_name}"
   location = "us-central1"
 
+  data_classification = "DATA_CLASSIFICATION_UNSPECIFIED"
   metadata_template = <<EOF
 {
   "name": "tf-test-template",
@@ -256,6 +259,7 @@ resource "google_dataplex_aspect_type" "test_aspect_type_basic" {
   project = "%{project_name}"
   location = "us-central1"
 
+  data_classification = "DATA_CLASSIFICATION_UNSPECIFIED"
   metadata_template = <<EOF
 {
   "name": "tf-test-template",
@@ -301,6 +305,7 @@ resource "google_dataplex_aspect_type" "test_aspect_type_basic" {
   project = "%{project_name}"
   location = "us-central1"
 
+  data_classification = "DATA_CLASSIFICATION_UNSPECIFIED"
   metadata_template = <<EOF
 {
   "name": "tf-test-template",

google-beta/services/dataplex/resource_dataplex_aspect_type.go

@@ -35,6 +35,7 @@ import (
 
 	"github.com/hashicorp/terraform-provider-google-beta/google-beta/tpgresource"
 	transport_tpg "github.com/hashicorp/terraform-provider-google-beta/google-beta/transport"
+	"github.com/hashicorp/terraform-provider-google-beta/google-beta/verify"
 )
 
 func ResourceDataplexAspectType() *schema.Resource {
@@ -66,6 +67,17 @@ func ResourceDataplexAspectType() *schema.Resource {
 				ForceNew:    true,
 				Description: `The aspect type id of the aspect type.`,
 			},
+			"data_classification": {
+				Type:             schema.TypeString,
+				Optional:         true,
+				ForceNew:         true,
+				ValidateFunc:     verify.ValidateEnum([]string{"DATA_CLASSIFICATION_UNSPECIFIED", "METADATA_AND_DATA", ""}),
+				DiffSuppressFunc: tpgresource.EmptyOrDefaultStringSuppress("DATA_CLASSIFICATION_UNSPECIFIED"),
+				Description: `Classifies the data stored by the aspect.
+'DATA_CLASSIFICATION_UNSPECIFIED' denotes that the aspect contains only metadata
+while 'METADATA_AND_DATA' indicates data derived content.
+<br><br> Possible values: ["DATA_CLASSIFICATION_UNSPECIFIED", "METADATA_AND_DATA"]`,
+			},
 			"description": {
 				Type:        schema.TypeString,
 				Optional:    true,
@@ -175,6 +187,12 @@ func resourceDataplexAspectTypeCreate(d *schema.ResourceData, meta interface{})
 	} else if v, ok := d.GetOkExists("metadata_template"); !tpgresource.IsEmptyValue(reflect.ValueOf(metadataTemplateProp)) && (ok || !reflect.DeepEqual(v, metadataTemplateProp)) {
 		obj["metadataTemplate"] = metadataTemplateProp
 	}
+	dataClassificationProp, err := expandDataplexAspectTypeDataClassification(d.Get("data_classification"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("data_classification"); !tpgresource.IsEmptyValue(reflect.ValueOf(dataClassificationProp)) && (ok || !reflect.DeepEqual(v, dataClassificationProp)) {
+		obj["dataClassification"] = dataClassificationProp
+	}
 	effectiveLabelsProp, err := expandDataplexAspectTypeEffectiveLabels(d.Get("effective_labels"), d, config)
 	if err != nil {
 		return err
@@ -307,6 +325,9 @@ func resourceDataplexAspectTypeRead(d *schema.ResourceData, meta interface{}) er
 	if err := d.Set("transfer_status", flattenDataplexAspectTypeTransferStatus(res["transferStatus"], d, config)); err != nil {
 		return fmt.Errorf("Error reading AspectType: %s", err)
 	}
+	if err := d.Set("data_classification", flattenDataplexAspectTypeDataClassification(res["dataClassification"], d, config)); err != nil {
+		return fmt.Errorf("Error reading AspectType: %s", err)
+	}
 	if err := d.Set("terraform_labels", flattenDataplexAspectTypeTerraformLabels(res["labels"], d, config)); err != nil {
 		return fmt.Errorf("Error reading AspectType: %s", err)
 	}
@@ -556,6 +577,10 @@ func flattenDataplexAspectTypeTransferStatus(v interface{}, d *schema.ResourceDa
 	return v
 }
 
+func flattenDataplexAspectTypeDataClassification(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	return v
+}
+
 func flattenDataplexAspectTypeTerraformLabels(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	if v == nil {
 		return v
@@ -595,6 +620,10 @@ func expandDataplexAspectTypeMetadataTemplate(v interface{}, d tpgresource.Terra
 	return m, nil
 }
 
+func expandDataplexAspectTypeDataClassification(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandDataplexAspectTypeEffectiveLabels(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (map[string]string, error) {
 	if v == nil {
 		return map[string]string{}, nil

google-beta/services/dataplex/resource_dataplex_aspect_type_generated_meta.yaml

@@ -8,6 +8,7 @@ fields:
   - field: 'aspect_type_id'
     provider_only: true
   - api_field: 'createTime'
+  - api_field: 'dataClassification'
   - api_field: 'description'
   - api_field: 'displayName'
   - field: 'effective_labels'

google-beta/services/dataplex/resource_dataplex_aspect_type_generated_test.go

@@ -64,6 +64,7 @@ resource "google_dataplex_aspect_type" "test_aspect_type_basic" {
   project = "%{project_name}"
   location = "us-central1"
 
+  data_classification = "DATA_CLASSIFICATION_UNSPECIFIED"
   metadata_template = <<EOF
 {
   "name": "tf-test-template",
@@ -129,7 +130,8 @@ resource "google_dataplex_aspect_type" "test_aspect_type_full" {
 
   labels = { "tag": "test-tf" }
   display_name = "terraform aspect type"
-  description = "aspect type created by Terraform"
+  description = "data aspect type created by Terraform"
+  data_classification = "METADATA_AND_DATA"
   metadata_template = <<EOF
 {
   "type": "record",

website/docs/r/dataplex_aspect_type.html.markdown

@@ -34,6 +34,7 @@ resource "google_dataplex_aspect_type" "test_aspect_type_basic" {
   project = "my-project-name"
   location = "us-central1"
 
+  data_classification = "DATA_CLASSIFICATION_UNSPECIFIED"
   metadata_template = <<EOF
 {
   "name": "tf-test-template",
@@ -73,7 +74,8 @@ resource "google_dataplex_aspect_type" "test_aspect_type_full" {
 
   labels = { "tag": "test-tf" }
   display_name = "terraform aspect type"
-  description = "aspect type created by Terraform"
+  description = "data aspect type created by Terraform"
+  data_classification = "METADATA_AND_DATA"
   metadata_template = <<EOF
 {
   "type": "record",
@@ -232,6 +234,14 @@ The following arguments are supported:
   (Optional)
   MetadataTemplate of the Aspect.
 
+* `data_classification` -
+  (Optional)
+  Classifies the data stored by the aspect.
+  `DATA_CLASSIFICATION_UNSPECIFIED` denotes that the aspect contains only metadata
+  while `METADATA_AND_DATA` indicates data derived content.
+  <br><br>
+  Possible values are: `DATA_CLASSIFICATION_UNSPECIFIED`, `METADATA_AND_DATA`.
+
 * `location` -
   (Optional)
   The location where aspect type will be created in.