Add support for Third Party Identity (#12604) (#9236)

[upstream:ca5a16cfc7771f028230d4b1f071aebdbada278f]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/12604.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+workbench: added `enable_third_party_identity` field to `google_workbench_instance` resource.
+```

google-beta/services/workbench/resource_workbench_instance.go

@@ -334,6 +334,12 @@ func ResourceWorkbenchInstance() *schema.Resource {
 				ForceNew:    true,
 				Description: `Optional. If true, the workbench instance will not register with the proxy.`,
 			},
+			"enable_third_party_identity": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Description: `Flag that specifies that a notebook can be accessed with third party
+identity provider.`,
+			},
 			"gce_setup": {
 				Type:        schema.TypeList,
 				Computed:    true,
@@ -860,6 +866,12 @@ func resourceWorkbenchInstanceCreate(d *schema.ResourceData, meta interface{}) e
 	} else if v, ok := d.GetOkExists("disable_proxy_access"); !tpgresource.IsEmptyValue(reflect.ValueOf(disableProxyAccessProp)) && (ok || !reflect.DeepEqual(v, disableProxyAccessProp)) {
 		obj["disableProxyAccess"] = disableProxyAccessProp
 	}
+	enableThirdPartyIdentityProp, err := expandWorkbenchInstanceEnableThirdPartyIdentity(d.Get("enable_third_party_identity"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("enable_third_party_identity"); !tpgresource.IsEmptyValue(reflect.ValueOf(enableThirdPartyIdentityProp)) && (ok || !reflect.DeepEqual(v, enableThirdPartyIdentityProp)) {
+		obj["enableThirdPartyIdentity"] = enableThirdPartyIdentityProp
+	}
 	labelsProp, err := expandWorkbenchInstanceEffectiveLabels(d.Get("effective_labels"), d, config)
 	if err != nil {
 		return err
@@ -1028,6 +1040,9 @@ func resourceWorkbenchInstanceRead(d *schema.ResourceData, meta interface{}) err
 	if err := d.Set("labels", flattenWorkbenchInstanceLabels(res["labels"], d, config)); err != nil {
 		return fmt.Errorf("Error reading Instance: %s", err)
 	}
+	if err := d.Set("enable_third_party_identity", flattenWorkbenchInstanceEnableThirdPartyIdentity(res["enableThirdPartyIdentity"], d, config)); err != nil {
+		return fmt.Errorf("Error reading Instance: %s", err)
+	}
 	if err := d.Set("terraform_labels", flattenWorkbenchInstanceTerraformLabels(res["labels"], d, config)); err != nil {
 		return fmt.Errorf("Error reading Instance: %s", err)
 	}
@@ -1060,6 +1075,12 @@ func resourceWorkbenchInstanceUpdate(d *schema.ResourceData, meta interface{}) e
 	} else if v, ok := d.GetOkExists("gce_setup"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, gceSetupProp)) {
 		obj["gceSetup"] = gceSetupProp
 	}
+	enableThirdPartyIdentityProp, err := expandWorkbenchInstanceEnableThirdPartyIdentity(d.Get("enable_third_party_identity"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("enable_third_party_identity"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, enableThirdPartyIdentityProp)) {
+		obj["enableThirdPartyIdentity"] = enableThirdPartyIdentityProp
+	}
 	labelsProp, err := expandWorkbenchInstanceEffectiveLabels(d.Get("effective_labels"), d, config)
 	if err != nil {
 		return err
@@ -1080,6 +1101,10 @@ func resourceWorkbenchInstanceUpdate(d *schema.ResourceData, meta interface{}) e
 		updateMask = append(updateMask, "gceSetup")
 	}
 
+	if d.HasChange("enable_third_party_identity") {
+		updateMask = append(updateMask, "enableThirdPartyIdentity")
+	}
+
 	if d.HasChange("effective_labels") {
 		updateMask = append(updateMask, "labels")
 	}
@@ -1732,6 +1757,10 @@ func flattenWorkbenchInstanceLabels(v interface{}, d *schema.ResourceData, confi
 	return transformed
 }
 
+func flattenWorkbenchInstanceEnableThirdPartyIdentity(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	return v
+}
+
 func flattenWorkbenchInstanceTerraformLabels(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	if v == nil {
 		return v
@@ -2288,6 +2317,10 @@ func expandWorkbenchInstanceDisableProxyAccess(v interface{}, d tpgresource.Terr
 	return v, nil
 }
 
+func expandWorkbenchInstanceEnableThirdPartyIdentity(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandWorkbenchInstanceEffectiveLabels(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (map[string]string, error) {
 	if v == nil {
 		return map[string]string{}, nil

google-beta/services/workbench/resource_workbench_instance_generated_meta.yaml

@@ -12,6 +12,7 @@ fields:
   - field: 'disable_proxy_access'
   - field: 'effective_labels'
     provider_only: true
+  - field: 'enable_third_party_identity'
   - field: 'gce_setup.accelerator_configs.core_count'
   - field: 'gce_setup.accelerator_configs.type'
   - field: 'gce_setup.boot_disk.disk_encryption'

google-beta/services/workbench/resource_workbench_instance_generated_test.go

@@ -332,6 +332,8 @@ resource "google_workbench_instance" "instance" {
 
   desired_state = "ACTIVE"
 
+  enable_third_party_identity = "true"
+
 }
 `, context)
 }

website/docs/r/workbench_instance.html.markdown

@@ -217,6 +217,8 @@ resource "google_workbench_instance" "instance" {
 
   desired_state = "ACTIVE"
 
+  enable_third_party_identity = "true"
+
 }
 ```
 
@@ -262,6 +264,11 @@ The following arguments are supported:
   **Note**: This field is non-authoritative, and will only manage the labels present in your configuration.
   Please refer to the field `effective_labels` for all of the labels present on the resource.
 
+* `enable_third_party_identity` -
+  (Optional)
+  Flag that specifies that a notebook can be accessed with third party
+  identity provider.
+
 * `instance_id` -
   (Optional)
   Required. User-defined unique ID of this instance.