Skip to content

Commit fb162e7

Browse files
promote logConfig to GA (#4822) (#3291)
Co-authored-by: upodroid <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: upodroid <[email protected]>
1 parent cf37b13 commit fb162e7

File tree

5 files changed

+11
-3
lines changed

5 files changed

+11
-3
lines changed

.changelog/4822.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
```release-note:enhancement
2+
compute: promoted `log_config` field of `google_compute_health_check` and `google_compute_region_health_check`
3+
```
4+
```release-note:enhancement
5+
compute: set the default value for log_config.enable on `google_compute_region_health_check` to avoid permanent diff on plan/apply.
6+
```

google-beta/resource_compute_region_health_check.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,7 @@ can only be ASCII.`,
385385
Optional: true,
386386
Description: `Indicates whether or not to export logs. This is false by default,
387387
which means no health check logging will be done.`,
388+
Default: false,
388389
},
389390
},
390391
},

google-beta/resource_dataproc_cluster_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ import (
1313
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
1414
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
1515

16-
dataproc "google.golang.org/api/dataproc/v1beta2"
1716
"google.golang.org/api/googleapi"
17+
18+
dataproc "google.golang.org/api/dataproc/v1beta2"
1819
)
1920

2021
func TestDataprocExtractInitTimeout(t *testing.T) {

website/docs/r/compute_health_check.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ The following arguments are supported:
428428
Structure is documented below.
429429

430430
* `log_config` -
431-
(Optional, [Beta](https://terraform.io/docs/providers/google/guides/provider_versions.html))
431+
(Optional)
432432
Configure logging on this health check.
433433
Structure is documented below.
434434

website/docs/r/compute_region_health_check.html.markdown

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ The following arguments are supported:
424424
Structure is documented below.
425425

426426
* `log_config` -
427-
(Optional, [Beta](https://terraform.io/docs/providers/google/guides/provider_versions.html))
427+
(Optional)
428428
Configure logging on this health check.
429429
Structure is documented below.
430430

0 commit comments

Comments
 (0)