Skip to content

Commit fbe1c75

Browse files
made sign_in in google_identity_platform_config O+C (#9001) (#6317)
Signed-off-by: Modular Magician <[email protected]>
1 parent dc3a8ec commit fbe1c75

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

.changelog/9001.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
identityplayform: fixed a potential perma-diff for `sign_in` in `google_identity_platform_config` resource
3+
```

google-beta/services/identityplatform/resource_identity_platform_config.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ func ResourceIdentityPlatformConfig() *schema.Resource {
157157
},
158158
"sign_in": {
159159
Type: schema.TypeList,
160+
Computed: true,
160161
Optional: true,
161162
Description: `Configuration related to local sign in methods.`,
162163
MaxItems: 1,

google-beta/services/identityplatform/resource_identity_platform_config_generated_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ resource "google_identity_platform_config" "default" {
119119
}
120120

121121
func TestAccIdentityPlatformConfig_identityPlatformConfigMinimalExample(t *testing.T) {
122-
acctest.SkipIfVcr(t)
123122
t.Parallel()
124123

125124
context := map[string]interface{}{
@@ -164,6 +163,10 @@ resource "google_project_service" "identitytoolkit" {
164163
165164
resource "google_identity_platform_config" "default" {
166165
project = google_project.default.project_id
166+
167+
depends_on = [
168+
google_project_service.identitytoolkit
169+
]
167170
}
168171
`, context)
169172
}

0 commit comments

Comments
 (0)