compute: used net.IP.Equal vs bytes.Equal for IP comparison (#12279) (#20241)

modular-magician · web-flow · commit 0a13ab78854d · 2024-11-08T10:25:11.000-08:00
[upstream:43b84b7308128de70332e50ff85c5f3713f66c1b]

Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/12279.txt b/.changelog/12279.txt
@@ -0,0 +1,3 @@
+```release-note:none
+
+```
diff --git a/google/services/compute/resource_compute_forwarding_rule.go b/google/services/compute/resource_compute_forwarding_rule.go
@@ -18,7 +18,6 @@
 package compute
 
 import (
-	"bytes"
 	"context"
 	"fmt"
 	"log"
@@ -89,7 +88,7 @@ func InternalIpDiffSuppress(_, old, new string, _ *schema.ResourceData) bool {
 			addr_equality = true
 		} else {
 			// old and new are IP addresses
-			addr_equality = bytes.Equal(addr_old, addr_new)
+			addr_equality = net.IP.Equal(addr_old, addr_new)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`package compute`
`19`	`19`
`20`	`20`	`import (`
`21`		`- "bytes"`
`22`	`21`	`"context"`
`23`	`22`	`"fmt"`
`24`	`23`	`"log"`
`@@ -89,7 +88,7 @@ func InternalIpDiffSuppress(_, old, new string, _ *schema.ResourceData) bool {`
`89`	`88`	`addr_equality = true`
`90`	`89`	`} else {`
`91`	`90`	`// old and new are IP addresses`
`92`		`- addr_equality = bytes.Equal(addr_old, addr_new)`
	`91`	`+ addr_equality = net.IP.Equal(addr_old, addr_new)`
`93`	`92`	`}`
`94`	`93`	`}`
`95`	`94`