Add access mode to compute region disk (#14358) (#23409)

[upstream:dd465f27fbe6d8e1ea70cd968afee7de13c8a565]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/14358.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+compute: added `access_mode` field to `google_compute_region_disk` resource
+```

google/services/compute/resource_compute_disk.go

@@ -385,11 +385,12 @@ character, which cannot be a dash.`,
 				Type:     schema.TypeString,
 				Computed: true,
 				Optional: true,
-				Description: `The accessMode of the disk.
+				Description: `The access mode of the disk.
 For example:
-* READ_WRITE_SINGLE
-* READ_WRITE_MANY
-* READ_ONLY_SINGLE`,
+  * READ_WRITE_SINGLE: The default AccessMode, means the disk can be attached to single instance in RW mode.
+  * READ_WRITE_MANY: The AccessMode means the disk can be attached to multiple instances in RW mode.
+  * READ_ONLY_SINGLE: The AccessMode means the disk can be attached to multiple instances in RO mode.
+The AccessMode is only valid for Hyperdisk disk types.`,
 			},
 			"architecture": {
 				Type:        schema.TypeString,

google/services/compute/resource_compute_region_disk.go

@@ -86,6 +86,17 @@ character, which cannot be a dash.`,
 					DiffSuppressFunc: tpgresource.CompareSelfLinkOrResourceName,
 				},
 			},
+			"access_mode": {
+				Type:     schema.TypeString,
+				Computed: true,
+				Optional: true,
+				Description: `The access mode of the disk.
+For example:
+  * READ_WRITE_SINGLE: The default AccessMode, means the disk can be attached to single instance in RW mode.
+  * READ_WRITE_MANY: The AccessMode means the disk can be attached to multiple instances in RW mode.
+  * READ_ONLY_SINGLE: The AccessMode means the disk can be attached to multiple instances in RO mode.
+The AccessMode is only valid for Hyperdisk disk types.`,
+			},
 			"async_primary_disk": {
 				Type:             schema.TypeList,
 				Optional:         true,
@@ -482,6 +493,12 @@ func resourceComputeRegionDiskCreate(d *schema.ResourceData, meta interface{}) e
 	} else if v, ok := d.GetOkExists("licenses"); !tpgresource.IsEmptyValue(reflect.ValueOf(licensesProp)) && (ok || !reflect.DeepEqual(v, licensesProp)) {
 		obj["licenses"] = licensesProp
 	}
+	accessModeProp, err := expandComputeRegionDiskAccessMode(d.Get("access_mode"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("access_mode"); !tpgresource.IsEmptyValue(reflect.ValueOf(accessModeProp)) && (ok || !reflect.DeepEqual(v, accessModeProp)) {
+		obj["accessMode"] = accessModeProp
+	}
 	labelsProp, err := expandComputeRegionDiskEffectiveLabels(d.Get("effective_labels"), d, config)
 	if err != nil {
 		return err
@@ -685,6 +702,9 @@ func resourceComputeRegionDiskRead(d *schema.ResourceData, meta interface{}) err
 	if err := d.Set("licenses", flattenComputeRegionDiskLicenses(res["licenses"], d, config)); err != nil {
 		return fmt.Errorf("Error reading RegionDisk: %s", err)
 	}
+	if err := d.Set("access_mode", flattenComputeRegionDiskAccessMode(res["accessMode"], d, config)); err != nil {
+		return fmt.Errorf("Error reading RegionDisk: %s", err)
+	}
 	if err := d.Set("terraform_labels", flattenComputeRegionDiskTerraformLabels(res["labels"], d, config)); err != nil {
 		return fmt.Errorf("Error reading RegionDisk: %s", err)
 	}
@@ -817,6 +837,51 @@ func resourceComputeRegionDiskUpdate(d *schema.ResourceData, meta interface{}) e
 			return err
 		}
 	}
+	if d.HasChange("access_mode") {
+		obj := make(map[string]interface{})
+
+		accessModeProp, err := expandComputeRegionDiskAccessMode(d.Get("access_mode"), d, config)
+		if err != nil {
+			return err
+		} else if v, ok := d.GetOkExists("access_mode"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, accessModeProp)) {
+			obj["accessMode"] = accessModeProp
+		}
+
+		url, err := tpgresource.ReplaceVars(d, config, "{{ComputeBasePath}}projects/{{project}}/regions/{{region}}/disks/{{name}}?paths=accessMode")
+		if err != nil {
+			return err
+		}
+
+		headers := make(http.Header)
+
+		// err == nil indicates that the billing_project value was found
+		if bp, err := tpgresource.GetBillingProject(d, config); err == nil {
+			billingProject = bp
+		}
+
+		res, err := transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
+			Config:    config,
+			Method:    "PATCH",
+			Project:   billingProject,
+			RawURL:    url,
+			UserAgent: userAgent,
+			Body:      obj,
+			Timeout:   d.Timeout(schema.TimeoutUpdate),
+			Headers:   headers,
+		})
+		if err != nil {
+			return fmt.Errorf("Error updating RegionDisk %q: %s", d.Id(), err)
+		} else {
+			log.Printf("[DEBUG] Finished updating RegionDisk %q: %#v", d.Id(), res)
+		}
+
+		err = ComputeOperationWaitTime(
+			config, res, project, "Updating RegionDisk", userAgent,
+			d.Timeout(schema.TimeoutUpdate))
+		if err != nil {
+			return err
+		}
+	}
 
 	d.Partial(false)
 
@@ -1270,6 +1335,10 @@ func flattenComputeRegionDiskLicenses(v interface{}, d *schema.ResourceData, con
 	return tpgresource.ConvertAndMapStringArr(v.([]interface{}), tpgresource.ConvertSelfLinkToV1)
 }
 
+func flattenComputeRegionDiskAccessMode(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	return v
+}
+
 func flattenComputeRegionDiskTerraformLabels(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	if v == nil {
 		return v
@@ -1507,6 +1576,10 @@ func expandComputeRegionDiskLicenses(v interface{}, d tpgresource.TerraformResou
 	return req, nil
 }
 
+func expandComputeRegionDiskAccessMode(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandComputeRegionDiskEffectiveLabels(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (map[string]string, error) {
 	if v == nil {
 		return map[string]string{}, nil

google/services/compute/resource_compute_region_disk_generated_meta.yaml

@@ -5,6 +5,7 @@ api_service_name: 'compute.googleapis.com'
 api_version: 'v1'
 api_resource_type_kind: 'Disk'
 fields:
+  - field: 'access_mode'
   - field: 'async_primary_disk.disk'
   - field: 'create_snapshot_before_destroy'
     provider_only: true

google/services/compute/resource_compute_region_disk_generated_test.go

@@ -186,6 +186,43 @@ resource "google_compute_region_disk" "regiondisk" {
 `, context)
 }
 
+func TestAccComputeRegionDisk_regionDiskHyperdiskBalancedHaWriteManyExample(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeRegionDiskDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeRegionDisk_regionDiskHyperdiskBalancedHaWriteManyExample(context),
+			},
+			{
+				ResourceName:            "google_compute_region_disk.primary",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"labels", "region", "snapshot", "terraform_labels", "type"},
+			},
+		},
+	})
+}
+
+func testAccComputeRegionDisk_regionDiskHyperdiskBalancedHaWriteManyExample(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_compute_region_disk" "primary" {
+  name                      = "tf-test-my-region-hyperdisk%{random_suffix}"
+  type                      = "hyperdisk-balanced-high-availability"
+  region                    = "us-central1"
+  replica_zones = ["us-central1-a", "us-central1-f"]
+  access_mode = "READ_WRITE_MANY"
+}
+`, context)
+}
+
 func testAccCheckComputeRegionDiskDestroyProducer(t *testing.T) func(s *terraform.State) error {
 	return func(s *terraform.State) error {
 		for name, rs := range s.RootModule().Resources {

website/docs/r/compute_disk.html.markdown

@@ -327,11 +327,12 @@ The following arguments are supported:
 
 * `access_mode` -
   (Optional)
-  The accessMode of the disk.
+  The access mode of the disk.
   For example:
-  * READ_WRITE_SINGLE
-  * READ_WRITE_MANY
-  * READ_ONLY_SINGLE
+    * READ_WRITE_SINGLE: The default AccessMode, means the disk can be attached to single instance in RW mode.
+    * READ_WRITE_MANY: The AccessMode means the disk can be attached to multiple instances in RW mode.
+    * READ_ONLY_SINGLE: The AccessMode means the disk can be attached to multiple instances in RO mode.
+  The AccessMode is only valid for Hyperdisk disk types.
 
 * `zone` -
   (Optional)

website/docs/r/compute_region_disk.html.markdown

@@ -145,6 +145,23 @@ resource "google_compute_region_disk" "regiondisk" {
   replica_zones = ["us-central1-a", "us-central1-f"]
 }
 ```
+<div class = "oics-button" style="float: right; margin: 0 0 -15px">
+  <a href="https://console.cloud.google.com/cloudshell/open?cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Fterraform-google-modules%2Fdocs-examples.git&cloudshell_image=gcr.io%2Fcloudshell-images%2Fcloudshell%3Alatest&cloudshell_print=.%2Fmotd&cloudshell_tutorial=.%2Ftutorial.md&cloudshell_working_dir=region_disk_hyperdisk_balanced_ha_write_many&open_in_editor=main.tf" target="_blank">
+    <img alt="Open in Cloud Shell" src="//gstatic.com/cloudssh/images/open-btn.svg" style="max-height: 44px; margin: 32px auto; max-width: 100%;">
+  </a>
+</div>
+## Example Usage - Region Disk Hyperdisk Balanced Ha Write Many
+
+
+```hcl
+resource "google_compute_region_disk" "primary" {
+  name                      = "my-region-hyperdisk"
+  type                      = "hyperdisk-balanced-high-availability"
+  region                    = "us-central1"
+  replica_zones = ["us-central1-a", "us-central1-f"]
+  access_mode = "READ_WRITE_MANY"
+}
+```
 
 ## Argument Reference
 
@@ -256,6 +273,15 @@ The following arguments are supported:
   (Optional)
   Any applicable license URI.
 
+* `access_mode` -
+  (Optional)
+  The access mode of the disk.
+  For example:
+    * READ_WRITE_SINGLE: The default AccessMode, means the disk can be attached to single instance in RW mode.
+    * READ_WRITE_MANY: The AccessMode means the disk can be attached to multiple instances in RW mode.
+    * READ_ONLY_SINGLE: The AccessMode means the disk can be attached to multiple instances in RO mode.
+  The AccessMode is only valid for Hyperdisk disk types.
+
 * `region` -
   (Optional)
   A reference to the region where the disk resides.