Fixes failing test: TestAccStorageBucketIamPolicy_destroy (#14404) (#23458)

[upstream:13819614703d20ce332fdfaff74898ad909854d4]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/14404.txt

@@ -0,0 +1 @@
+unknown: Fixes failing test: TestAccStorageBucketIamPolicy_destroy

google/services/storage/iam_storage_bucket_test.go

@@ -346,12 +346,16 @@ func TestAccStorageBucket_iamPolicyGeneratedWithCondition(t *testing.T) {
 func TestAccStorageBucketIamPolicy_destroy(t *testing.T) {
 	t.Parallel()
 
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
 	acctest.VcrTest(t, resource.TestCase{
 		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
 		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
 		Steps: []resource.TestStep{
 			{
-				Config: testAccStorageBucketIamPolicy_destroy(),
+				Config: testAccStorageBucketIamPolicy_destroy(context),
 			},
 		},
 	})
@@ -617,14 +621,14 @@ resource "google_storage_bucket_iam_policy" "foo" {
 `, context)
 }
 
-func testAccStorageBucketIamPolicy_destroy() string {
-	return fmt.Sprintf(`
+func testAccStorageBucketIamPolicy_destroy(context map[string]interface{}) string {
+	return acctest.Nprintf(`
 resource "google_service_account" "accessor" {
   account_id = "pub-sub-test-service-account"
 }
 
 resource "google_storage_bucket" "test_bucket" {
-  name          = "sd-pubsub-test-bucket"
+  name          = "tf-test-my-bucket%{random_suffix}"
   location      = "US"
   storage_class = "STANDARD"
 
@@ -674,5 +678,5 @@ resource "google_pubsub_topic_iam_policy" "topic_policy" {
   topic       = google_pubsub_topic.topic.name
   policy_data = data.google_iam_policy.topic_policy_data.policy_data
 }
-`)
+`, context)
 }