Skip to content

Commit 2e47a64

Browse files
Add suspended field to dataplex data scan rules (#14167) (#23456)
[upstream:25f30023f1cdb08aa80337accb36ba49b8eb076c] Signed-off-by: Modular Magician <[email protected]>
1 parent 49dd615 commit 2e47a64

File tree

5 files changed

+31
-0
lines changed

5 files changed

+31
-0
lines changed

.changelog/14167.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
dataplex: added `suspended` field to `google_dataplex_datascan` resource
3+
```

google/services/dataplex/resource_dataplex_datascan.go

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -651,6 +651,12 @@ Only relevant if a minValue has been defined. Default = false.`,
651651
},
652652
},
653653
},
654+
"suspended": {
655+
Type: schema.TypeBool,
656+
Optional: true,
657+
Description: `Whether the Rule is active or suspended. Default = false.`,
658+
Default: false,
659+
},
654660
"table_condition_expectation": {
655661
Type: schema.TypeList,
656662
Optional: true,
@@ -1512,6 +1518,7 @@ func flattenDataplexDatascanDataQualitySpecRules(v interface{}, d *schema.Resour
15121518
"dimension": flattenDataplexDatascanDataQualitySpecRulesDimension(original["dimension"], d, config),
15131519
"threshold": flattenDataplexDatascanDataQualitySpecRulesThreshold(original["threshold"], d, config),
15141520
"name": flattenDataplexDatascanDataQualitySpecRulesName(original["name"], d, config),
1521+
"suspended": flattenDataplexDatascanDataQualitySpecRulesSuspended(original["suspended"], d, config),
15151522
"description": flattenDataplexDatascanDataQualitySpecRulesDescription(original["description"], d, config),
15161523
"range_expectation": flattenDataplexDatascanDataQualitySpecRulesRangeExpectation(original["rangeExpectation"], d, config),
15171524
"non_null_expectation": flattenDataplexDatascanDataQualitySpecRulesNonNullExpectation(original["nonNullExpectation"], d, config),
@@ -1546,6 +1553,10 @@ func flattenDataplexDatascanDataQualitySpecRulesName(v interface{}, d *schema.Re
15461553
return v
15471554
}
15481555

1556+
func flattenDataplexDatascanDataQualitySpecRulesSuspended(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
1557+
return v
1558+
}
1559+
15491560
func flattenDataplexDatascanDataQualitySpecRulesDescription(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
15501561
return v
15511562
}
@@ -2392,6 +2403,13 @@ func expandDataplexDatascanDataQualitySpecRules(v interface{}, d tpgresource.Ter
23922403
transformed["name"] = transformedName
23932404
}
23942405

2406+
transformedSuspended, err := expandDataplexDatascanDataQualitySpecRulesSuspended(original["suspended"], d, config)
2407+
if err != nil {
2408+
return nil, err
2409+
} else if val := reflect.ValueOf(transformedSuspended); val.IsValid() && !tpgresource.IsEmptyValue(val) {
2410+
transformed["suspended"] = transformedSuspended
2411+
}
2412+
23952413
transformedDescription, err := expandDataplexDatascanDataQualitySpecRulesDescription(original["description"], d, config)
23962414
if err != nil {
23972415
return nil, err
@@ -2487,6 +2505,10 @@ func expandDataplexDatascanDataQualitySpecRulesName(v interface{}, d tpgresource
24872505
return v, nil
24882506
}
24892507

2508+
func expandDataplexDatascanDataQualitySpecRulesSuspended(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
2509+
return v, nil
2510+
}
2511+
24902512
func expandDataplexDatascanDataQualitySpecRulesDescription(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
24912513
return v, nil
24922514
}

google/services/dataplex/resource_dataplex_datascan_generated_meta.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ fields:
5252
- field: 'data_quality_spec.rules.statistic_range_expectation.statistic'
5353
- field: 'data_quality_spec.rules.statistic_range_expectation.strict_max_enabled'
5454
- field: 'data_quality_spec.rules.statistic_range_expectation.strict_min_enabled'
55+
- field: 'data_quality_spec.rules.suspended'
5556
- field: 'data_quality_spec.rules.table_condition_expectation.sql_expression'
5657
- field: 'data_quality_spec.rules.threshold'
5758
- field: 'data_quality_spec.rules.uniqueness_expectation'

google/services/dataplex/resource_dataplex_datascan_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,7 @@ resource "google_dataplex_datascan" "full_quality" {
238238
strict_min_enabled = true
239239
strict_max_enabled = false
240240
}
241+
suspended = true
241242
}
242243
}
243244

website/docs/r/dataplex_datascan.html.markdown

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -577,6 +577,10 @@ The following arguments are supported:
577577
Must start with a letter.
578578
Must end with a number or a letter.
579579

580+
* `suspended` -
581+
(Optional)
582+
Whether the Rule is active or suspended. Default = false.
583+
580584
* `description` -
581585
(Optional)
582586
Description of the rule.

0 commit comments

Comments
 (0)