Fix perma-diff in google_identity_platform_config for default false values (#13622) (#22384)

[upstream:a44a0e051327ef244f6e89f403e70d3fd28b017f]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/13622.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+identityplatform: Fixed perma-diff in `google_identity_platform_config`
+```

google/services/identityplatform/resource_identity_platform_config.go

@@ -1016,32 +1016,35 @@ func flattenIdentityPlatformConfigBlockingFunctionsTriggersUpdateTime(v interfac
 }
 
 func flattenIdentityPlatformConfigBlockingFunctionsForwardInboundCredentials(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
-	if v == nil {
-		return nil
-	}
-	original := v.(map[string]interface{})
-	if len(original) == 0 {
-		return nil
-	}
 	transformed := make(map[string]interface{})
-	transformed["id_token"] =
-		flattenIdentityPlatformConfigBlockingFunctionsForwardInboundCredentialsIdToken(original["idToken"], d, config)
-	transformed["access_token"] =
-		flattenIdentityPlatformConfigBlockingFunctionsForwardInboundCredentialsAccessToken(original["accessToken"], d, config)
-	transformed["refresh_token"] =
-		flattenIdentityPlatformConfigBlockingFunctionsForwardInboundCredentialsRefreshToken(original["refreshToken"], d, config)
-	return []interface{}{transformed}
-}
-func flattenIdentityPlatformConfigBlockingFunctionsForwardInboundCredentialsIdToken(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
-	return v
-}
 
-func flattenIdentityPlatformConfigBlockingFunctionsForwardInboundCredentialsAccessToken(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
-	return v
-}
+	if v == nil {
+		transformed["id_token"] = false
+		transformed["access_token"] = false
+		transformed["refresh_token"] = false
+	} else {
+		original := v.(map[string]interface{})
 
-func flattenIdentityPlatformConfigBlockingFunctionsForwardInboundCredentialsRefreshToken(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
-	return v
+		if original["idToken"] == nil {
+			transformed["id_token"] = false
+		} else {
+			transformed["id_token"] = original["idToken"]
+		}
+
+		if original["accessToken"] == nil {
+			transformed["access_token"] = false
+		} else {
+			transformed["access_token"] = original["accessToken"]
+		}
+
+		if original["refreshToken"] == nil {
+			transformed["refresh_token"] = false
+		} else {
+			transformed["refresh_token"] = original["refreshToken"]
+		}
+	}
+
+	return []interface{}{transformed}
 }
 
 func flattenIdentityPlatformConfigQuota(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
@@ -1279,26 +1282,25 @@ func flattenIdentityPlatformConfigMfaProviderConfigsTotpProviderConfigAdjacentIn
 }
 
 func flattenIdentityPlatformConfigMultiTenant(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	transformed := make(map[string]interface{})
+
 	if v == nil {
 		return nil
+	} else {
+		original := v.(map[string]interface{})
+
+		if original["allowTenants"] == nil {
+			transformed["allow_tenants"] = false
+		} else {
+			transformed["allow_tenants"] = original["allowTenants"]
+		}
+
+		if original["defaultTenantLocation"] != nil {
+			transformed["default_tenant_location"] = original["defaultTenantLocation"]
+		}
 	}
-	original := v.(map[string]interface{})
-	if len(original) == 0 {
-		return nil
-	}
-	transformed := make(map[string]interface{})
-	transformed["allow_tenants"] =
-		flattenIdentityPlatformConfigMultiTenantAllowTenants(original["allowTenants"], d, config)
-	transformed["default_tenant_location"] =
-		flattenIdentityPlatformConfigMultiTenantDefaultTenantLocation(original["defaultTenantLocation"], d, config)
-	return []interface{}{transformed}
-}
-func flattenIdentityPlatformConfigMultiTenantAllowTenants(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
-	return v
-}
 
-func flattenIdentityPlatformConfigMultiTenantDefaultTenantLocation(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
-	return v
+	return []interface{}{transformed}
 }
 
 func flattenIdentityPlatformConfigMonitoring(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {

google/services/identityplatform/resource_identity_platform_config_generated_test.go

@@ -257,6 +257,7 @@ resource "google_identity_platform_config" "default" {
   project = google_project.default.project_id
   autodelete_anonymous_users = false
   sign_in {
+    allow_duplicate_emails = false
    
     anonymous {
         enabled = false
@@ -268,6 +269,31 @@ resource "google_identity_platform_config" "default" {
         enabled = false
     }
   }
+  blocking_functions {
+    triggers {
+      event_type   = "beforeSignIn"
+      function_uri = "https://us-east1-tf-test-my-project-2%{random_suffix}.cloudfunctions.net/before-sign-in"
+    }
+    forward_inbound_credentials {
+      refresh_token = false
+      access_token  = false
+      id_token      = false
+    }
+  }
+  client {
+    permissions {
+      disabled_user_signup = false
+      disabled_user_deletion = false
+    }
+  }
+  multi_tenant {
+    allow_tenants = false
+  }
+  monitoring {
+    request_logging {
+      enabled = false
+    }
+  }
 }
 `, context)
 }