Skip to content

Commit 51acec9

Browse files
updated google_compute_node_group and google_compute_node_template name property to be required (#14272) (#23345)
[upstream:cdf998bbda4eef7ea60d34a111b053b74c37b552] Signed-off-by: Modular Magician <[email protected]>
1 parent 64ae8aa commit 51acec9

File tree

5 files changed

+20
-19
lines changed

5 files changed

+20
-19
lines changed

.changelog/14272.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
unknown: updated google_compute_node_group and google_compute_node_template name property to be required

google/services/compute/resource_compute_node_group.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,11 @@ func ResourceComputeNodeGroup() *schema.Resource {
5959
),
6060

6161
Schema: map[string]*schema.Schema{
62+
"name": {
63+
Type: schema.TypeString,
64+
Required: true,
65+
Description: `Name of the resource.`,
66+
},
6267
"node_template": {
6368
Type: schema.TypeString,
6469
Required: true,
@@ -136,11 +141,6 @@ than or equal to max-nodes. The default value is 0.`,
136141
},
137142
},
138143
},
139-
"name": {
140-
Type: schema.TypeString,
141-
Optional: true,
142-
Description: `Name of the resource.`,
143-
},
144144
"share_settings": {
145145
Type: schema.TypeList,
146146
Computed: true,

google/services/compute/resource_compute_node_template.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,12 @@ func ResourceComputeNodeTemplate() *schema.Resource {
5454
),
5555

5656
Schema: map[string]*schema.Schema{
57+
"name": {
58+
Type: schema.TypeString,
59+
Required: true,
60+
ForceNew: true,
61+
Description: `Name of the resource.`,
62+
},
5763
"accelerators": {
5864
Type: schema.TypeList,
5965
Optional: true,
@@ -122,12 +128,6 @@ node template`,
122128
},
123129
},
124130
},
125-
"name": {
126-
Type: schema.TypeString,
127-
Optional: true,
128-
ForceNew: true,
129-
Description: `Name of the resource.`,
130-
},
131131
"node_affinity_labels": {
132132
Type: schema.TypeMap,
133133
Optional: true,

website/docs/r/compute_node_group.html.markdown

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,10 @@ resource "google_compute_node_group" "nodes" {
154154
The following arguments are supported:
155155

156156

157+
* `name` -
158+
(Required)
159+
Name of the resource.
160+
157161
* `node_template` -
158162
(Required)
159163
The URL of the node template to which this node group belongs.
@@ -166,10 +170,6 @@ The following arguments are supported:
166170
(Optional)
167171
An optional textual description of the resource.
168172

169-
* `name` -
170-
(Optional)
171-
Name of the resource.
172-
173173
* `initial_size` -
174174
(Optional)
175175
The initial number of nodes in the node group. One of `initial_size` or `autoscaling_policy` must be configured on resource creation.

website/docs/r/compute_node_template.html.markdown

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,10 @@ resource "google_compute_node_template" "template" {
129129
The following arguments are supported:
130130

131131

132+
* `name` -
133+
(Required)
134+
Name of the resource.
135+
132136

133137
- - -
134138

@@ -137,10 +141,6 @@ The following arguments are supported:
137141
(Optional)
138142
An optional textual description of the resource.
139143

140-
* `name` -
141-
(Optional)
142-
Name of the resource.
143-
144144
* `node_affinity_labels` -
145145
(Optional)
146146
Labels to use for node affinity, which will be used in

0 commit comments

Comments
 (0)