Fix: Make "match" field in Route Policy's terms as required (#14402) (#23494)

[upstream:ffbd59a8ad9749e1eefb503808df8ff3f1b42093]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/14402.txt

@@ -0,0 +1 @@
+unknown: Fix: Make "match" field in Route Policy's terms as required

google/services/compute/resource_compute_router_route_policy.go

@@ -77,6 +77,36 @@ func ResourceComputeRouterRoutePolicy() *schema.Resource {
 				Description: `List of terms (the order in the list is not important, they are evaluated in order of priority).`,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
+						"match": {
+							Type:        schema.TypeList,
+							Required:    true,
+							Description: `CEL expression evaluated against a route to determine if this term applies (see Policy Language).`,
+							MaxItems:    1,
+							Elem: &schema.Resource{
+								Schema: map[string]*schema.Schema{
+									"expression": {
+										Type:        schema.TypeString,
+										Required:    true,
+										Description: `Textual representation of an expression in Common Expression Language syntax.`,
+									},
+									"description": {
+										Type:        schema.TypeString,
+										Optional:    true,
+										Description: `Description of the expression`,
+									},
+									"location": {
+										Type:        schema.TypeString,
+										Optional:    true,
+										Description: `String indicating the location of the expression for error reporting, e.g. a file name and a position in the file`,
+									},
+									"title": {
+										Type:        schema.TypeString,
+										Optional:    true,
+										Description: `Title for the expression, i.e. a short string describing its purpose.`,
+									},
+								},
+							},
+						},
 						"priority": {
 							Type:        schema.TypeInt,
 							Required:    true,
@@ -114,36 +144,6 @@ purpose.`,
 								},
 							},
 						},
-						"match": {
-							Type:        schema.TypeList,
-							Optional:    true,
-							Description: `CEL expression evaluated against a route to determine if this term applies (see Policy Language). When not set, the term applies to all routes.`,
-							MaxItems:    1,
-							Elem: &schema.Resource{
-								Schema: map[string]*schema.Schema{
-									"expression": {
-										Type:        schema.TypeString,
-										Required:    true,
-										Description: `Textual representation of an expression in Common Expression Language syntax.`,
-									},
-									"description": {
-										Type:        schema.TypeString,
-										Optional:    true,
-										Description: `Description of the expression`,
-									},
-									"location": {
-										Type:        schema.TypeString,
-										Optional:    true,
-										Description: `String indicating the location of the expression for error reporting, e.g. a file name and a position in the file`,
-									},
-									"title": {
-										Type:        schema.TypeString,
-										Optional:    true,
-										Description: `Title for the expression, i.e. a short string describing its purpose.`,
-									},
-								},
-							},
-						},
 					},
 				},
 			},

website/docs/r/compute_router_route_policy.html.markdown

@@ -157,8 +157,8 @@ The following arguments are supported:
   The evaluation priority for this term, which must be between 0 (inclusive) and 231 (exclusive), and unique within the list.
 
 * `match` -
-  (Optional)
-  CEL expression evaluated against a route to determine if this term applies (see Policy Language). When not set, the term applies to all routes.
+  (Required)
+  CEL expression evaluated against a route to determine if this term applies (see Policy Language).
   Structure is [documented below](#nested_terms_terms_match).
 
 * `actions` -