fix noop for optional and required fields (#14879) (#24040)

[upstream:17df8f64871653f837bcbfc3de065a03267a6f60]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

google/services/iap/data_source_iap_client.go

@@ -32,12 +32,8 @@ func DataSourceIapClient() *schema.Resource {
 
 	dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(rs)
 
-	// Set 'Required' schema elements
 	tpgresource.AddRequiredFieldsToSchema(dsSchema, "brand", "client_id")
 
-	// Set 'Optional' schema elements
-	tpgresource.AddOptionalFieldsToSchema(dsSchema)
-
 	return &schema.Resource{
 		Read:   dataSourceIapClientRead,
 		Schema: dsSchema,

google/services/storagecontrol/data_source_storage_control_folder_intelligence_config.go

@@ -32,12 +32,8 @@ func DataSourceStorageControlFolderIntelligenceConfig() *schema.Resource {
 
 	dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(rs)
 
-	// Set 'Required' schema elements
 	tpgresource.AddRequiredFieldsToSchema(dsSchema, "name")
 
-	// Set 'Optional' schema elements
-	tpgresource.AddOptionalFieldsToSchema(dsSchema)
-
 	return &schema.Resource{
 		Read:   dataSourceStorageControlFolderIntelligenceConfigRead,
 		Schema: dsSchema,

google/services/storagecontrol/data_source_storage_control_organization_intelligence_config.go

@@ -32,12 +32,8 @@ func DataSourceStorageControlOrganizationIntelligenceConfig() *schema.Resource {
 
 	dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(rs)
 
-	// Set 'Required' schema elements
 	tpgresource.AddRequiredFieldsToSchema(dsSchema, "name")
 
-	// Set 'Optional' schema elements
-	tpgresource.AddOptionalFieldsToSchema(dsSchema)
-
 	return &schema.Resource{
 		Read:   dataSourceStorageControlOrganizationIntelligenceConfigRead,
 		Schema: dsSchema,

google/services/storagecontrol/data_source_storage_control_project_intelligence_config.go

@@ -32,12 +32,8 @@ func DataSourceStorageControlProjectIntelligenceConfig() *schema.Resource {
 
 	dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(rs)
 
-	// Set 'Required' schema elements
 	tpgresource.AddRequiredFieldsToSchema(dsSchema, "name")
 
-	// Set 'Optional' schema elements
-	tpgresource.AddOptionalFieldsToSchema(dsSchema)
-
 	return &schema.Resource{
 		Read:   dataSourceStorageControlProjectIntelligenceConfigRead,
 		Schema: dsSchema,