Fix for unable to set bgp_always_compare_med in google_compute_network from true to false (#14424) (#23477)

[upstream:14bb73bd4034b5015206b319f46c3f39619c509e]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/14424.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+compute: fixed an issue with `bgp_always_compare_med` in `google_compute_network` where it was unable to be set from `true` to `false`
+```

google/services/compute/resource_compute_network.go

@@ -947,7 +947,16 @@ func resourceComputeNetworkEncoder(d *schema.ResourceData, meta interface{}, obj
 }
 
 func resourceComputeNetworkUpdateEncoder(d *schema.ResourceData, meta interface{}, obj map[string]interface{}) (map[string]interface{}, error) {
-	delete(obj, "numeric_id") // Field doesn't exist in the API
+	//  BGP always-compare-med
+	if d.HasChange("bgp_always_compare_med") {
+		if _, ok := obj["routingConfig"]; !ok {
+			obj["routingConfig"] = make(map[string]interface{})
+		}
+		obj["routingConfig"].(map[string]interface{})["bgpAlwaysCompareMed"] = d.Get("bgp_always_compare_med").(bool)
+	}
+
+	// now clean up the rest
+	delete(obj, "numeric_id")
 	return obj, nil
 }
 

google/services/compute/resource_compute_network_test.go

@@ -223,6 +223,14 @@ func TestAccComputeNetwork_bgpAlwaysCompareMedAndUpdate(t *testing.T) {
 					resource.TestCheckResourceAttr("google_compute_network.acc_network_bgp_always_compare_med", "bgp_always_compare_med", "true"),
 				),
 			},
+			{
+				Config: testAccComputeNetwork_bgp_always_compare_med(networkName, false),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckComputeNetworkExists(
+						t, "google_compute_network.acc_network_bgp_always_compare_med", &network),
+					resource.TestCheckResourceAttr("google_compute_network.acc_network_bgp_always_compare_med", "bgp_always_compare_med", "false"),
+				),
+			},
 		},
 	})
 }